aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/rules
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-03-27 16:19:21 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-03-27 16:21:32 -0700
commita579d65c52b3348c5a336fca6e44ab1e69ed7170 (patch)
treee8a241678970d70c06b3cfbaa61868ccfcfb9349 /src/test/java/com/google/devtools/build/lib/rules
parent7292497d51ab20fdff74252de58a14fddb5276ee (diff)
Replace nearly all test uses of ConfiguredTarget#getConfiguration with utility method getConfiguration(ConfiguredTarget). Done using IntelliJ structural replace, with
$val$.getConfiguration() -> getConfiguration($val$) and Expression type: TransitiveInfoCollection, applying constraint within type hierarchy. Had to clean up a few compile errors. PiperOrigin-RevId: 190692493
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/rules')
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java3
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/AndroidLibraryTest.java3
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkTest.java28
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java2
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java54
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelperTest.java4
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/objc/AppleBinaryTest.java4
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/objc/BazelJ2ObjcLibraryTest.java29
8 files changed, 63 insertions, 64 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java
index 3a4015fb20..9b81ffcd66 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBinaryTest.java
@@ -1602,8 +1602,7 @@ public class AndroidBinaryTest extends AndroidBuildViewTestCase {
// No prefix should be added because of resource filtering.
assertThat(
- binary
- .getConfiguration()
+ getConfiguration(binary)
.getFragment(AndroidConfiguration.class)
.getOutputDirectoryName())
.isNull();
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLibraryTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLibraryTest.java
index d1a3954e94..e9bbb6e7de 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLibraryTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLibraryTest.java
@@ -1590,8 +1590,7 @@ public class AndroidLibraryTest extends AndroidBuildViewTestCase {
ConfiguredTarget genruleTarget = getConfiguredTarget("//java/srclessdeps:some_genrule");
ConfiguredTarget target = getDirectPrerequisite(genruleTarget, "//java/srclessdeps:foo");
assertThat(
- target
- .getConfiguration()
+ getConfiguration(target)
.getFragment(AndroidConfiguration.class)
.allowSrcsLessAndroidLibraryDeps())
.isTrue();
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkTest.java
index c34e1ccdcc..7957e5d697 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidSkylarkTest.java
@@ -76,11 +76,11 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
assertThat(splitDeps).containsKey("armeabi-v7a");
assertThat(splitDeps.get("k8")).hasSize(2);
assertThat(splitDeps.get("armeabi-v7a")).hasSize(2);
- assertThat(splitDeps.get("k8").get(0).getConfiguration().getCpu()).isEqualTo("k8");
- assertThat(splitDeps.get("k8").get(1).getConfiguration().getCpu()).isEqualTo("k8");
- assertThat(splitDeps.get("armeabi-v7a").get(0).getConfiguration().getCpu())
+ assertThat(getConfiguration(splitDeps.get("k8").get(0)).getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(splitDeps.get("k8").get(1)).getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(splitDeps.get("armeabi-v7a").get(0)).getCpu())
.isEqualTo("armeabi-v7a");
- assertThat(splitDeps.get("armeabi-v7a").get(1).getConfiguration().getCpu())
+ assertThat(getConfiguration(splitDeps.get("armeabi-v7a").get(1)).getCpu())
.isEqualTo("armeabi-v7a");
// Check that ctx.split_attr.dep has this structure (that is, that the values are not lists):
@@ -93,8 +93,8 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
(Map<String, ConfiguredTarget>) target.get("split_attr_dep");
assertThat(splitDep).containsKey("k8");
assertThat(splitDep).containsKey("armeabi-v7a");
- assertThat(splitDep.get("k8").getConfiguration().getCpu()).isEqualTo("k8");
- assertThat(splitDep.get("armeabi-v7a").getConfiguration().getCpu()).isEqualTo("armeabi-v7a");
+ assertThat(getConfiguration(splitDep.get("k8")).getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(splitDep.get("armeabi-v7a")).getCpu()).isEqualTo("armeabi-v7a");
// The regular ctx.attr.deps should be a single list with all the branches of the split merged
// together (i.e. for aspects).
@@ -103,7 +103,7 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
assertThat(attrDeps).hasSize(4);
ListMultimap<String, Object> attrDepsMap = ArrayListMultimap.create();
for (ConfiguredTarget ct : attrDeps) {
- attrDepsMap.put(ct.getConfiguration().getCpu(), target);
+ attrDepsMap.put(getConfiguration(ct).getCpu(), target);
}
assertThat(attrDepsMap).valuesForKey("k8").hasSize(2);
assertThat(attrDepsMap).valuesForKey("armeabi-v7a").hasSize(2);
@@ -115,7 +115,7 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
assertThat(attrDep).hasSize(2);
ListMultimap<String, Object> attrDepMap = ArrayListMultimap.create();
for (ConfiguredTarget ct : attrDep) {
- attrDepMap.put(ct.getConfiguration().getCpu(), target);
+ attrDepMap.put(getConfiguration(ct).getCpu(), target);
}
assertThat(attrDepMap).valuesForKey("k8").hasSize(1);
assertThat(attrDepMap).valuesForKey("armeabi-v7a").hasSize(1);
@@ -124,8 +124,8 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
@SuppressWarnings("unchecked")
List<ConfiguredTarget> k8Deps = (List<ConfiguredTarget>) target.get("k8_deps");
assertThat(k8Deps).hasSize(2);
- assertThat(k8Deps.get(0).getConfiguration().getCpu()).isEqualTo("k8");
- assertThat(k8Deps.get(1).getConfiguration().getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(k8Deps.get(0)).getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(k8Deps.get(1)).getCpu()).isEqualTo("k8");
}
@Test
@@ -144,8 +144,8 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
String cpu = "armeabi-v7a";
assertThat(splitDeps.get(cpu)).hasSize(2);
- assertThat(splitDeps.get(cpu).get(0).getConfiguration().getCpu()).isEqualTo(cpu);
- assertThat(splitDeps.get(cpu).get(1).getConfiguration().getCpu()).isEqualTo(cpu);
+ assertThat(getConfiguration(splitDeps.get(cpu).get(0)).getCpu()).isEqualTo(cpu);
+ assertThat(getConfiguration(splitDeps.get(cpu).get(1)).getCpu()).isEqualTo(cpu);
}
@Test
@@ -161,8 +161,8 @@ public class AndroidSkylarkTest extends BuildViewTestCase {
// Split transition isn't in effect, so the deps are compiled normally (i.e. using --cpu).
assertThat(splitDeps.get(Runtime.NONE)).hasSize(2);
- assertThat(splitDeps.get(Runtime.NONE).get(0).getConfiguration().getCpu()).isEqualTo("k8");
- assertThat(splitDeps.get(Runtime.NONE).get(1).getConfiguration().getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(splitDeps.get(Runtime.NONE).get(0)).getCpu()).isEqualTo("k8");
+ assertThat(getConfiguration(splitDeps.get(Runtime.NONE).get(1)).getCpu()).isEqualTo("k8");
}
@Test
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
index e44cd778d2..584a930867 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
@@ -998,7 +998,7 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase {
")");
ConfiguredTarget target = getConfiguredTarget("//foo");
CppCompileAction action = getCppCompileAction(target);
- String genfilesDir = target.getConfiguration().getGenfilesFragment().toString();
+ String genfilesDir = getConfiguration(target).getGenfilesFragment().toString();
// Local include paths come first.
assertContainsSublist(
action.getCompilerOptions(),
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java
index a3ddc7710d..02365f10bb 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainTest.java
@@ -108,7 +108,7 @@ public class CcToolchainTest extends BuildViewTestCase {
(CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useInterfaceSharedObjects(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
useConfiguration("--interface_shared_objects");
@@ -116,7 +116,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useInterfaceSharedObjects(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
getAnalysisMock()
@@ -132,7 +132,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useInterfaceSharedObjects(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
useConfiguration("--nointerface_shared_objects");
@@ -140,7 +140,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useInterfaceSharedObjects(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
}
@@ -180,7 +180,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
// Mode-specific settings.
@@ -189,7 +189,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
useConfiguration("-c", "dbg", "--fission=opt");
@@ -197,7 +197,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
useConfiguration("-c", "dbg", "--fission=opt,dbg");
@@ -205,7 +205,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
useConfiguration("-c", "fastbuild", "--fission=opt,dbg");
@@ -213,7 +213,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
useConfiguration("-c", "fastbuild", "--fission=opt,dbg");
@@ -221,7 +221,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
// Universally enabled
@@ -230,7 +230,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
useConfiguration("-c", "opt", "--fission=yes");
@@ -238,7 +238,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
useConfiguration("-c", "fastbuild", "--fission=yes");
@@ -246,7 +246,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isTrue();
// Universally disabled
@@ -255,7 +255,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
useConfiguration("-c", "opt", "--fission=no");
@@ -263,7 +263,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
useConfiguration("-c", "fastbuild", "--fission=no");
@@ -271,7 +271,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.useFission(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isFalse();
}
@@ -374,7 +374,7 @@ public class CcToolchainTest extends BuildViewTestCase {
(CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.getDynamicMode(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isEqualTo(DynamicMode.OFF);
useConfiguration("--lipo=off", "--lipo_context=//foo");
@@ -382,7 +382,7 @@ public class CcToolchainTest extends BuildViewTestCase {
toolchainProvider = (CcToolchainProvider) target.get(ToolchainInfo.PROVIDER);
assertThat(
CppHelper.getDynamicMode(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isEqualTo(DynamicMode.DEFAULT);
}
@@ -417,7 +417,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertThat(
CppHelper.getDynamicMode(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isEqualTo(DynamicMode.DEFAULT);
// Test "off"
@@ -427,7 +427,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertThat(
CppHelper.getDynamicMode(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isEqualTo(DynamicMode.OFF);
// Test "fully"
@@ -437,7 +437,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertThat(
CppHelper.getDynamicMode(
- target.getConfiguration().getFragment(CppConfiguration.class), toolchainProvider))
+ getConfiguration(target).getFragment(CppConfiguration.class), toolchainProvider))
.isEqualTo(DynamicMode.FULLY);
// Check an invalid value for disable_dynamic.
@@ -510,7 +510,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertDoesNotContainSublist(
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
Collections.emptyList()),
"--param",
@@ -537,13 +537,13 @@ public class CcToolchainTest extends BuildViewTestCase {
String defaultSettingFalse = "crosstool_default_false";
List<String> copts =
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
Collections.emptyList());
assertThat(copts).doesNotContain("-DDEFAULT_FALSE");
copts =
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
ImmutableList.of(defaultSettingFalse));
assertThat(copts).contains("-DDEFAULT_FALSE");
@@ -554,7 +554,7 @@ public class CcToolchainTest extends BuildViewTestCase {
copts =
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
ImmutableList.of(defaultSettingFalse));
assertThat(copts).contains("-DDEFAULT_FALSE");
@@ -574,7 +574,7 @@ public class CcToolchainTest extends BuildViewTestCase {
List<String> expected = new ArrayList<>();
expected.addAll(
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
Collections.emptyList()));
expected.add("-Dfoo");
@@ -585,7 +585,7 @@ public class CcToolchainTest extends BuildViewTestCase {
assertThat(
ImmutableList.copyOf(
CppHelper.getCompilerOptions(
- lib.getConfiguration().getFragment(CppConfiguration.class),
+ getConfiguration(lib).getFragment(CppConfiguration.class),
toolchain,
Collections.emptyList())))
.isEqualTo(ImmutableList.copyOf(expected));
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelperTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelperTest.java
index f5a42439ff..c2f5b77c4b 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelperTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CppLinkstampCompileHelperTest.java
@@ -63,7 +63,7 @@ public class CppLinkstampCompileHelperTest extends BuildViewTestCase {
List<String> arguments = linkstampCompileAction.getArguments();
assertThatArgumentsAreValid(
arguments,
- target.getConfiguration().getFragment(CppConfiguration.class).toString(),
+ getConfiguration(target).getFragment(CppConfiguration.class).toString(),
target.getLabel().getCanonicalForm(),
executable.getFilename());
}
@@ -119,7 +119,7 @@ public class CppLinkstampCompileHelperTest extends BuildViewTestCase {
List<String> arguments = linkstampCompileAction.getArguments();
assertThatArgumentsAreValid(
arguments,
- target.getConfiguration().getFragment(CppConfiguration.class).toString(),
+ getConfiguration(target).getFragment(CppConfiguration.class).toString(),
target.getLabel().getCanonicalForm(),
executable.getFilename());
}
diff --git a/src/test/java/com/google/devtools/build/lib/rules/objc/AppleBinaryTest.java b/src/test/java/com/google/devtools/build/lib/rules/objc/AppleBinaryTest.java
index 7862f5a1f2..46168736d2 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/objc/AppleBinaryTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/objc/AppleBinaryTest.java
@@ -108,8 +108,8 @@ public class AppleBinaryTest extends ObjcRuleTestCase {
ConfiguredTarget a = getConfiguredTarget("//a:a");
ConfiguredTarget b = getDirectPrerequisite(a, "//a:b");
- PathFragment aPath = a.getConfiguration().getOutputDirectory(RepositoryName.MAIN).getExecPath();
- PathFragment bPath = b.getConfiguration().getOutputDirectory(RepositoryName.MAIN).getExecPath();
+ PathFragment aPath = getConfiguration(a).getOutputDirectory(RepositoryName.MAIN).getExecPath();
+ PathFragment bPath = getConfiguration(b).getOutputDirectory(RepositoryName.MAIN).getExecPath();
assertThat(aPath.getPathString()).doesNotMatch("-min[0-9]");
assertThat(bPath.getPathString()).contains("-min7.0-");
diff --git a/src/test/java/com/google/devtools/build/lib/rules/objc/BazelJ2ObjcLibraryTest.java b/src/test/java/com/google/devtools/build/lib/rules/objc/BazelJ2ObjcLibraryTest.java
index 6a72c21ef9..df0569b701 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/objc/BazelJ2ObjcLibraryTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/objc/BazelJ2ObjcLibraryTest.java
@@ -103,8 +103,9 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
TestConstants.TOOLS_REPOSITORY_PATH_PREFIX + "third_party/java/j2objc/jre_core.h",
"java/com/google/dummy/test/_j2objc/test/java/com/google/dummy/test/test.h");
- String execPath = j2objcLibraryTarget.getConfiguration().getBinDirectory(RepositoryName.MAIN)
- .getExecPath() + "/";
+ String execPath =
+ getConfiguration(j2objcLibraryTarget).getBinDirectory(RepositoryName.MAIN).getExecPath()
+ + "/";
assertThat(
Iterables.transform(
provider.get(ObjcProvider.INCLUDE), PathFragment::getSafePathString))
@@ -132,7 +133,7 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
ConfiguredTarget target = getConfiguredTarget("//java/com/google/test:transpile");
ObjcProvider provider = target.get(ObjcProvider.SKYLARK_CONSTRUCTOR);
- String genfilesFragment = target.getConfiguration().getGenfilesFragment().toString();
+ String genfilesFragment = getConfiguration(target).getGenfilesFragment().toString();
assertThat(Artifact.toRootRelativePaths(provider.get(ObjcProvider.LIBRARY)))
.containsExactly(
TestConstants.TOOLS_REPOSITORY_PATH_PREFIX
@@ -145,8 +146,8 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
+ genfilesFragment
+ "/java/com/google/test/test.h");
- String execPath = target.getConfiguration().getBinDirectory(RepositoryName.MAIN)
- .getExecPath() + "/";
+ String execPath =
+ getConfiguration(target).getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
assertThat(
Iterables.transform(
provider.get(ObjcProvider.INCLUDE), PathFragment::getSafePathString))
@@ -425,8 +426,8 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
Artifact mappingFile = getFirstArtifactEndingWith(
mappingFileProvider.getHeaderMappingFiles(), "lib1.mapping.j2objc");
SpawnAction headerMappingAction = (SpawnAction) getGeneratingAction(mappingFile);
- String execPath = target.getConfiguration().getBinDirectory(RepositoryName.MAIN)
- .getExecPath() + "/";
+ String execPath =
+ getConfiguration(target).getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
assertThat(Artifact.toRootRelativePaths(headerMappingAction.getInputs()))
.containsAllOf(
"java/com/google/transpile/libOne.java", "java/com/google/transpile/jar.srcjar");
@@ -550,7 +551,7 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
"java/com/google/dummy/test/_j2objc/test/java/com/google/dummy/test/test.h");
String execPath =
- objcTarget.getConfiguration().getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
+ getConfiguration(objcTarget).getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
assertThat(
Iterables.transform(
provider.get(ObjcProvider.INCLUDE), PathFragment::getSafePathString))
@@ -596,7 +597,7 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
"app/_j2objc/dummyTwo/app/dummyTwo.h");
String execPath =
- objcTarget.getConfiguration().getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
+ getConfiguration(objcTarget).getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
assertThat(
Iterables.transform(
provider.get(ObjcProvider.INCLUDE), PathFragment::getSafePathString))
@@ -630,7 +631,7 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
List<String> linkArgs = normalizeBashArgs(linkAction.getArguments());
ConfiguredTarget target = getConfiguredTargetInAppleBinaryTransition("//x:test");
String binDir =
- target.getConfiguration().getBinDirectory(RepositoryName.MAIN).getExecPathString();
+ getConfiguration(target).getBinDirectory(RepositoryName.MAIN).getExecPathString();
Artifact fileList = getFirstArtifactEndingWith(linkAction.getInputs(), "test-linker.objlist");
ParameterFileWriteAction filelistWriteAction =
(ParameterFileWriteAction) getGeneratingAction(fileList);
@@ -887,7 +888,7 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
Artifact archiveSourceMappingFile =
getBinArtifact("test.archive_source_mapping.j2objc", javaTarget);
String execPath =
- javaTarget.getConfiguration().getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
+ getConfiguration(javaTarget).getBinDirectory(RepositoryName.MAIN).getExecPath() + "/";
ParameterFileWriteAction paramFileAction =
(ParameterFileWriteAction) getGeneratingAction(paramFile);
@@ -978,10 +979,10 @@ public class BazelJ2ObjcLibraryTest extends J2ObjcLibraryTest {
ConfiguredTarget j2objcLibraryTarget =
getConfiguredTarget("//java/com/google/dummy/test:transpile");
String genfilesFragment =
- j2objcLibraryTarget.getConfiguration().getGenfilesFragment().toString();
- String binFragment = j2objcLibraryTarget.getConfiguration().getBinFragment().toString();
+ getConfiguration(j2objcLibraryTarget).getGenfilesFragment().toString();
+ String binFragment = getConfiguration(j2objcLibraryTarget).getBinFragment().toString();
AppleConfiguration appleConfiguration =
- j2objcLibraryTarget.getConfiguration().getFragment(AppleConfiguration.class);
+ getConfiguration(j2objcLibraryTarget).getFragment(AppleConfiguration.class);
String commandLine = Joiner.on(" ").join(compileAction.getArguments());
ImmutableList<String> expectedArgs =