aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/rules
diff options
context:
space:
mode:
authorGravatar cpeyser <cpeyser@google.com>2018-03-26 11:55:42 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-03-26 11:56:56 -0700
commit8acb017b6625cb0d306966496ccb336f8dd35722 (patch)
tree5402b0f6e42c890c3885f44e4b3c5aeb3586f3af /src/test/java/com/google/devtools/build/lib/rules
parentcfc3432003a1a65ee9ef4046e8dc248363f9bcca (diff)
Prohibit using Java serialization for protos.
PiperOrigin-RevId: 190500851
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/rules')
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java16
1 files changed, 15 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java
index 01a50fc72b..5cdc60419b 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java
@@ -20,6 +20,7 @@ import static org.junit.Assert.fail;
import com.google.common.base.Joiner;
import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterables;
import com.google.common.collect.Multimap;
@@ -37,6 +38,8 @@ import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables.Str
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables.StructureBuilder;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables.VariableValue;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.Variables.VariableValueBuilder;
+import com.google.devtools.build.lib.skyframe.serialization.AutoRegistry;
+import com.google.devtools.build.lib.skyframe.serialization.ObjectCodecs;
import com.google.devtools.build.lib.skyframe.serialization.testutils.SerializationTester;
import com.google.devtools.build.lib.testutil.FoundationTestCase;
import com.google.devtools.build.lib.testutil.TestUtils;
@@ -118,7 +121,7 @@ public class CcToolchainFeaturesTest extends FoundationTestCase {
}
@Test
- public void testCodec() throws Exception {
+ public void testFeatureConfigurationCodec() throws Exception {
FeatureConfiguration emptyConfiguration =
buildFeatures("").getFeatureConfiguration(ImmutableSet.of());
FeatureConfiguration emptyFeatures =
@@ -162,6 +165,17 @@ public class CcToolchainFeaturesTest extends FoundationTestCase {
}
@Test
+ public void testCrosstoolProtoCanBeSerialized() throws Exception {
+ ObjectCodecs objectCodecs =
+ new ObjectCodecs(AutoRegistry.get().getBuilder().build(), ImmutableMap.of());
+ objectCodecs.serialize(CToolchain.WithFeatureSet.getDefaultInstance());
+ objectCodecs.serialize(CToolchain.VariableWithValue.getDefaultInstance());
+ objectCodecs.serialize(CToolchain.FlagGroup.getDefaultInstance());
+ objectCodecs.serialize(CToolchain.FlagSet.getDefaultInstance());
+ objectCodecs.serialize(CToolchain.EnvSet.getDefaultInstance());
+ }
+
+ @Test
public void testUnconditionalFeature() throws Exception {
assertThat(buildFeatures("").getFeatureConfiguration(ImmutableSet.of("a")).isEnabled("a"))
.isFalse();