diff options
| author |  Laszlo Csomor <laszlocsomor@google.com> | 2017-01-03 15:21:08 +0000 |
|---|---|---|
| committer |  John Cater <jcater@google.com> | 2017-01-03 16:43:40 +0000 |
| commit | 8679e4c53889f8ccfa33dcb89ebc59c0e55c10ae (patch) | |
| tree | 551c434cea3e5ac9cefb4ab4666f48fe0751c9d0 /src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java | |
| parent | c9139896d49a12d69ca34fd47b3fa9d35c5a69a8 (diff) | |
Windows: resolve shortened paths
TL;DR: resolve "C:/progra~1" style paths, don't
cache failed resolutions in the parent's
Path.children
When creating WindowsPath objects, resolve the
"C:/progra~1" style paths to "C:/program files".
This enables us to correctly compare paths on
Windows. Without this canonicalization we
incorrectly determine "C:/progra~1" and
"C:/program files" to be different when they are
actually the same.
We only attempt to resolve such paths if the name
looks like it's an abbreviated path.
If resolution fails, probably due to the path not
existing, then we don't cache this Path object in
the parent's `children` list. This avoids stale
cache entries in case the path springs into
existence later in the server's lifetime.
Fixes https://github.com/bazelbuild/bazel/issues/2145
We also need to rectify https://github.com/bazelbuild/bazel/issues/2173
--
PiperOrigin-RevId: 143442134
MOS_MIGRATED_REVID=143442134
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainFeaturesTest.java')
0 files changed, 0 insertions, 0 deletions