Handle multiple crosstool features providing the same symbol cleanly

It's bad to crash with an exception, let's show proper rule error instead.

RELNOTES: None.
PiperOrigin-RevId: 162916138

1 files changed, 20 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
index e7b7671c31..8695ac517a 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
@@ -905,6 +905,26 @@ public class CcCommonTest extends BuildViewTestCase {
         .doesNotContain("third_party/_virtual_includes/a/third_party/a.h");
   }
 
+  @Test
+  public void
+  testConfigureFeaturesDoesntCrashOnCollidingFeaturesExceptionButReportsRuleErrorCleanly()
+      throws Exception {
+    getAnalysisMock()
+        .ccSupport()
+        .setupCrosstool(
+            mockToolsConfig,
+            "feature { name: 'a1' provides: 'a' }",
+            "feature { name: 'a2' provides: 'a' }");
+    useConfiguration("--features=a1", "--features=a2");
+
+    scratch.file("x/BUILD", "cc_library(name = 'foo', srcs = ['a.cc'])");
+    scratch.file("x/a.cc");
+
+    reporter.removeHandler(failFastHandler);
+    getConfiguredTarget("//x:foo");
+    assertContainsEvent("Symbol a is provided by all of the following features: a1 a2");
+  }
+
   /**
    * A {@code toolchain_type} rule for testing that only supports C++.
    */