diff options
| author |  janakr <janakr@google.com> | 2017-10-10 03:22:21 +0200 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-10-10 11:22:49 +0200 |
| commit | 1cde8722b930f1c9cf5346f887a0b293bae49f1f (patch) | |
| tree | fc690c495c8c4534f7b1fc7ff989f528fc53f11a /src/test/java/com/google/devtools/build/lib/repository | |
| parent | 6f411661984a9be358c5b457b31c88368d6fdd63 (diff) | |
Allow NodeEntry implementations to keep just deps, as opposed to all edges or no edges. Also add option to disable checks in MemoizingEvaluatorTest that don't make sense for implementations that don't keep track of dirty nodes. Also extract RecordingDifferencer to an interface. And add a test for the situation that a node changes during a build that it's not requested, and which fails, necessitating cleanup.
PiperOrigin-RevId: 171616817
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/repository')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/repository/ExternalPackageUtilTest.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/repository/ExternalPackageUtilTest.java b/src/test/java/com/google/devtools/build/lib/repository/ExternalPackageUtilTest.java index 488b554d68..aa537287a9 100644 --- a/src/test/java/com/google/devtools/build/lib/repository/ExternalPackageUtilTest.java +++ b/src/test/java/com/google/devtools/build/lib/repository/ExternalPackageUtilTest.java @@ -54,6 +54,7 @@ import com.google.devtools.build.skyframe.InMemoryMemoizingEvaluator; import com.google.devtools.build.skyframe.LegacySkyKey; import com.google.devtools.build.skyframe.MemoizingEvaluator; import com.google.devtools.build.skyframe.RecordingDifferencer; +import com.google.devtools.build.skyframe.SequencedRecordingDifferencer; import com.google.devtools.build.skyframe.SequentialBuildDriver; import com.google.devtools.build.skyframe.SkyFunction; import com.google.devtools.build.skyframe.SkyFunctionException; @@ -128,7 +129,7 @@ public class ExternalPackageUtilTest extends BuildViewTestCase { skyFunctions.put(GET_RULE_BY_NAME_FUNCTION, new GetRuleByNameFunction()); skyFunctions.put(GET_REGISTERED_TOOLCHAINS_FUNCTION, new GetRegisteredToolchainsFunction()); - RecordingDifferencer differencer = new RecordingDifferencer(); + RecordingDifferencer differencer = new SequencedRecordingDifferencer(); MemoizingEvaluator evaluator = new InMemoryMemoizingEvaluator(skyFunctions, differencer); driver = new SequentialBuildDriver(evaluator); PrecomputedValue.PATH_PACKAGE_LOCATOR.set(differencer, pkgLocator.get()); |