Tolerate NoSuchPackageException when processing subdirectories.

In RecursiveDirectoryTraversalFunction, we must tolerate
NoSuchPackageException being thrown by subdirectories' nodes, since
that can happen in a nokeep_going build.

--
Change-Id: Id9a48256aa209775f27130186c58e03c788d20a9
Reviewed-on: https://bazel-review.googlesource.com/#/c/3392/5
MOS_MIGRATED_REVID=120081575

1 files changed, 15 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java b/src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java
index dc32181c88..68b9f64a35 100644
--- a/src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java
+++ b/src/test/java/com/google/devtools/build/lib/pkgcache/TargetPatternEvaluatorTest.java
@@ -676,6 +676,21 @@ public class TargetPatternEvaluatorTest extends AbstractTargetPatternEvaluatorTe
     }
   }
 
+  @Test
+  public void testSubdirectoryCircularSymlinkNoKeepGoingPrimedParent() throws Exception {
+    setupSubDirectoryCircularSymlink();
+    // We make sure that the parent package is present, so that in the subsequent nokeep_going
+    // build, the pattern parsing will have as many of its deps available as possible, which
+    // exercises more code coverage during error bubbling.
+    assertThat(parseList("//parent:all")).containsExactly(Label.parseAbsolute("//parent:parent"));
+    try {
+      parseList("//parent/...");
+      fail();
+    } catch (TargetParsingException e) {
+      // Expected.
+    }
+  }
+
   /** Regression test for bug: "Bogus 'helpful' error message" */
   @Test
   public void testHelpfulMessageForFileOutsideOfAnyPackage() throws Exception {