Open source LoadingPhaseRunnerTest and its Skyframe companion.

I had to make a small change to ExternalFilesHelper. The Bazel test setup
creates a remote repository for the tools, so we always have external files,
incl. during loading. However, some of the tests don't setup an output
directory, but instead pass null, which would lead to a crash.

--
MOS_MIGRATED_REVID=110669993

1 files changed, 26 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/pkgcache/SkyframeLoadingPhaseRunnerTest.java b/src/test/java/com/google/devtools/build/lib/pkgcache/SkyframeLoadingPhaseRunnerTest.java
new file mode 100644
index 0000000000..0686a37b4d
--- /dev/null
+++ b/src/test/java/com/google/devtools/build/lib/pkgcache/SkyframeLoadingPhaseRunnerTest.java
@@ -0,0 +1,26 @@
+// Copyright 2015 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package com.google.devtools.build.lib.pkgcache;
+
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/** Tests for the Skyframe-based implementation of {@link LoadingPhaseRunner}. */
+@RunWith(JUnit4.class)
+public final class SkyframeLoadingPhaseRunnerTest extends LoadingPhaseRunnerTest {
+  @Override
+  protected boolean runsLoadingPhase() {
+    return false;
+  }
+}