diff options
| author |  janakr <janakr@google.com> | 2017-09-22 13:27:14 -0400 |
|---|---|---|
| committer |  John Cater <jcater@google.com> | 2017-09-25 09:37:41 -0400 |
| commit | 52d05e880e453698be7ae9486020ad21977339ad (patch) | |
| tree | e91d144d50e06b290b5c2991a4ba11e423c29569 /src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java | |
| parent | ff3e01cf8ad1f3d59902a267f158e6be9fa52495 (diff) | |
Inject BlazeDirectories into FdoSupportFunction directly, instead of depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them.
The goal is getting rid of the precomputed value entirely, but since this change necessitated a fair number of testing changes, I'm mailing this out as a first step.
PiperOrigin-RevId: 169705474
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java b/src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java index fb7581b24f..e43d35432d 100644 --- a/src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java +++ b/src/test/java/com/google/devtools/build/lib/pkgcache/BuildFileModificationTest.java @@ -81,7 +81,7 @@ public class BuildFileModificationTest extends FoundationTestCase { skyframeExecutor = SequencedSkyframeExecutor.create( analysisMock - .getPackageFactoryBuilderForTesting() + .getPackageFactoryBuilderForTesting(directories) .build(ruleClassProvider, scratch.getFileSystem()), directories, null, /* BinTools */ @@ -89,7 +89,7 @@ public class BuildFileModificationTest extends FoundationTestCase { ruleClassProvider.getBuildInfoFactories(), ImmutableList.<DiffAwareness.Factory>of(), Predicates.<PathFragment>alwaysFalse(), - AnalysisMock.get().getSkyFunctions(), + analysisMock.getSkyFunctions(directories), ImmutableList.<PrecomputedValue.Injected>of(), ImmutableList.<SkyValueDirtinessChecker>of(), PathFragment.EMPTY_FRAGMENT, |