diff options
| author |  lpino <lpino@google.com> | 2018-07-18 05:55:23 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-07-18 05:56:59 -0700 |
| commit | 5fe7ed0f6ddb600e86c32b2a52c7f094418f1afb (patch) | |
| tree | ddf1377c2b3be9d3d48ccf9a703d0c7888caf80a /src/test/java/com/google/devtools/build/lib/analysis | |
| parent | a1a57a519d49fcbda35f3df0e68e04ba09db3362 (diff) | |
When applying an aspect to a generated file of a Fileset avoid creating the FilesetEntryMap for the aspect's RuleContext.
The current logic in createFilesetEntryMap() uses the rule of the RuleContext.Builder to determine whether to create a filesetEntryMap or not, because of this, applying an aspect to a generated file of a fileset (e.g. 'out' attribute of a Fileset) causes createFilesetEntryMap to create the map even though the associated target is, for instance, a generated file. As a consequence, applying any aspect to a generated file of a fileset causes a NullPointerException.
PiperOrigin-RevId: 205065778
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java index 9baa24938a..4d732a3955 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewForTesting.java @@ -503,12 +503,12 @@ public class BuildViewForTesting { return new RuleContext.Builder( env, - (Rule) target, + target, ImmutableList.of(), targetConfig, configurations.getHostConfiguration(), ruleClassProvider.getPrerequisiteValidator(), - ((Rule) target).getRuleClassObject().getConfigurationFragmentPolicy()) + target.getAssociatedRule().getRuleClassObject().getConfigurationFragmentPolicy()) .setVisibility( NestedSetBuilder.create( Order.STABLE_ORDER, |