diff options
author | 2017-07-18 09:21:33 +0200 | |
---|---|---|
committer | 2017-07-18 09:49:23 +0200 | |
commit | 33cd68e18f554b98194b4ce924580d3333ab9217 (patch) | |
tree | 2b7ed87b0543fc5591bc9e74ed7e46d72e74007f /src/test/java/com/google/devtools/build/lib/analysis | |
parent | c238b573aef850ecc4c2a7bdb49233de225d6b12 (diff) |
Automated rollback of commit a76c94be7c56b93fc5a2f9ececfba7ac1f61f69c.
*** Reason for rollback ***
Caused memory regression.
*** Original change description ***
CustomCommandLine.Builder: clean up its interface
In this commit:
- remove unused methods and classes
- turn CustomCommandLine.ArgvFragment into an
interface
- remove the
CustomCommandLine.TreeFileArtifactArgvFragment
abstract class; it only had one remaining
subclass
- add @Nullable annotations where nulls are fine
- add Precondition checks for non-nullable args
- simplify the interface by removing add* methods
that can be composed of other add* methods; this
makes it easier to see...
***
RELNOTES: none
PiperOrigin-RevId: 162320031
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/actions/ParamFileWriteActionTest.java | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/actions/ParamFileWriteActionTest.java b/src/test/java/com/google/devtools/build/lib/analysis/actions/ParamFileWriteActionTest.java index 6e5de2fce5..8711b47a4b 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/actions/ParamFileWriteActionTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/actions/ParamFileWriteActionTest.java @@ -132,9 +132,7 @@ public class ParamFileWriteActionTest extends BuildViewTestCase { return CustomCommandLine.builder() .add("--flag1") .add("--flag2") - .add("--flag3") - .add("value1") - .add("value2") + .add("--flag3", ImmutableList.of("value1", "value2")) .build(); } |