diff options
| author |  janakr <janakr@google.com> | 2018-06-20 15:22:33 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-20 15:23:54 -0700 |
| commit | c19284e3e8db5ed57097ed908c76dc902392c7ee (patch) | |
| tree | 9bcd7b0b90afa18e0eb70e8854fa09b937386548 /src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java | |
| parent | bccf9c63ff0863e3ffb4fb24085a37a03db10aaa (diff) | |
Remove all uses of RuleDefinitionEnvironment#getLabel, replacing them with Label.parseAbsoluteUnchecked. Label already interns all labels, so the additional interning being done in every ConfiguredRuleClass.Builder was pointless memory and CPU.
Keeping the RuleDefinitionEnvironment around makes things harder to serialize.
Done using IntelliJ structural replace and then a super-painful adding of imports to every file that didn't compile (have to learn a better way to do this).
PiperOrigin-RevId: 201427027
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java b/src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java index 6e4ce84399..63fa86cb40 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/whitelisting/WhitelistDummyRule.java @@ -21,6 +21,7 @@ import com.google.devtools.build.lib.analysis.RuleConfiguredTargetFactory; import com.google.devtools.build.lib.analysis.RuleContext; import com.google.devtools.build.lib.analysis.RunfilesProvider; import com.google.devtools.build.lib.analysis.util.MockRule; +import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; import com.google.devtools.build.lib.collect.nestedset.Order; @@ -34,7 +35,7 @@ public final class WhitelistDummyRule { (builder, env) -> builder.add( Whitelist.getAttributeFromWhitelistName("dummy") - .value(env.getLabel("//whitelist:whitelist")))); + .value(Label.parseAbsoluteUnchecked("//whitelist:whitelist")))); /** Has to be public to make factory initialization logic happy. **/ public static class RuleFactory implements RuleConfiguredTargetFactory { |