Reimplement the configuration sanity check as a per-fragment check.

This is conceptually better (because each fragment should be
self-contained), and gives us better performance, as we no longer need to
load all explicit labels.

--
MOS_MIGRATED_REVID=118674470

1 files changed, 0 insertions, 6 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
index dd799993e6..541356f75f 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
@@ -264,11 +264,6 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
 
   protected final BuildConfigurationCollection createConfigurations(String... args)
       throws Exception {
-    return createConfigurations(false, args);
-  }
-
-  protected final BuildConfigurationCollection createConfigurations(
-      boolean sanityCheck, String... args) throws Exception {
     optionsParser = OptionsParser.newOptionsParser(Iterables.concat(Arrays.asList(
           ExecutionOptions.class,
           BuildRequest.BuildRequestOptions.class),
@@ -286,7 +281,6 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
           new InvocationPolicyEnforcer(TestConstants.TEST_INVOCATION_POLICY);
     optionsPolicyEnforcer.enforce(optionsParser, "");
 
-    configurationFactory.setSanityCheck(sanityCheck);
     BuildOptions buildOptions = ruleClassProvider.createBuildOptions(optionsParser);
     ensureTargetsVisited(buildOptions.getAllLabels().values());
     skyframeExecutor.invalidateConfigurationCollection();