diff options
| author |  gregce <gregce@google.com> | 2017-07-27 22:09:34 +0200 |
|---|---|---|
| committer |  Jakob Buchgraber <buchgr@google.com> | 2017-07-28 10:44:52 +0200 |
| commit | da4c959603280ded71ad8fbc2d30d4917b175750 (patch) | |
| tree | dd201d03665350c1fec5247eba18af0bea4dd205 /src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java | |
| parent | d8235cf959ac1326836064aa9442256b69f7318a (diff) | |
Fix confusing semantics for Attribute.Builder.allowedRuleClasses.
1) Update the javadocs.
2) Clarify that allowedRuleClases and allowedRuleClassesWithWarning
must be disjoint sets.
3) Enforce 2).
4) Fix error messaging when only "with warnings" is set.
PiperOrigin-RevId: 163379567
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java b/src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java index 9446a04ded..bba074bec4 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/MockRule.java @@ -102,6 +102,11 @@ public interface MockRule extends RuleDefinition { } /** + * Default <code>"deps"</code> attribute for rule classes that don't need special behavior. + */ + Attribute.Builder<?> DEPS_ATTRIBUTE = attr("deps", BuildType.LABEL_LIST).allowedFileTypes(); + + /** * Builds out this rule with default attributes Blaze expects of all rules plus the custom * attributes defined by this implementation's {@link State}. * @@ -110,7 +115,6 @@ public interface MockRule extends RuleDefinition { @Override default RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment environment) { builder - .add(attr("deps", BuildType.LABEL_LIST).allowedFileTypes()) .add(attr("testonly", BOOLEAN).nonconfigurable("test").value(false)) .add(attr("deprecation", STRING).nonconfigurable("test").value((String) null)) .add(attr("tags", STRING_LIST)) |