Clean up analysis error reporting a bit:

1. Make --analysis_warnings_as_errors a no-op.
2. Stop doing a sanity check that we didn't succeed in analysis even with errors emitted.
3. As a result, emit an error about shared actions to the proper listener.

--
MOS_MIGRATED_REVID=92262247

1 files changed, 2 insertions, 4 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java
index 54f2593ff4..de8bc7aeb8 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestCase.java
@@ -89,9 +89,8 @@ public abstract class AnalysisTestCase extends FoundationTestCase {
   private static final int LOADING_PHASE_THREADS = 20;
 
   /** All the flags that can be passed to {@link BuildView#update}. */
-  public static enum Flag {
-    KEEP_GOING,
-    ANALYSIS_WARNINGS_AS_ERRORS,
+  public enum Flag {
+    KEEP_GOING
   }
 
   /** Helper class to make it easy to enable and disable flags. */
@@ -238,7 +237,6 @@ public abstract class AnalysisTestCase extends FoundationTestCase {
 
     BuildView.Options viewOptions = optionsParser.getOptions(BuildView.Options.class);
     viewOptions.keepGoing = flags.contains(Flag.KEEP_GOING);
-    viewOptions.analysisWarningsAsErrors = flags.contains(Flag.ANALYSIS_WARNINGS_AS_ERRORS);
 
     BuildOptions buildOptions = ruleClassProvider.createBuildOptions(optionsParser);
     PackageCacheOptions packageCacheOptions = optionsParser.getOptions(PackageCacheOptions.class);