aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
diff options
context:
space:
mode:
authorGravatar Yun Peng <pcloudy@google.com>2017-09-15 15:59:14 +0200
committerGravatar László Csomor <laszlocsomor@google.com>2017-09-18 11:25:37 +0200
commit394211bf88b88c25036429e99894fa7c60eaaace (patch)
treea5a99354a9f3b8530bb0d98d61d8844b21348ecd /src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
parentf8480fac37692083b2f9c4e69b9b9e9e2c9b1853 (diff)
Bazel now can build dynamic library from cc_library
Working towards: https://github.com/bazelbuild/bazel/issues/3311 When building dynamic library on Windows, Bazel builds an import library and a DLL. Bazel provides a feature called windows_export_all_symbols, if this feature is enabled(and no_windows_export_all_symbols is not) for a cc_library, then Bazel parses object files of that cc_library to generate a DEF file that will be used during linking time to export symbols from DLL. This feature can be specified at crosstool, package, target and command line level. A few differences from Unix platforms: 1. We don't build the shared library on Windows by default, users have to specifiy --output_groups=dynamic_library for building dynamic libraries. This output group is also available on other platforms. 2. By default, cc_test is dynamically linked on Unix, but it will be statically linked on Windows by default. (meaning the default value of linkstatic in cc_test is 1 on Windows, and 0 on other platforms) 3. For global data symbols, __declspec(dllimport) must still be used in source files. Remaining issues: 1. Extensions for import library and DLL are not correct yet. 2. DLLs are not guaranteed to be available during runtime yet. 3. Diamond problem If a cc_library A is specified as linkstatic=0, then no dynamic library will be built for it, so if another cc_library B depends on it, A will be statically linked into B, and if a cc_binary C depends on B, A will also be statically linked into C and B will be dynamically linked to C. This is wrong because A is duplicated in both B and C. It is essentially a diamond problem describled in C++ Transitive Library. (https://docs.google.com/document/d/1-tv0_79zGyBoDmaP_pYWaBVUwHUteLpAs90_rUl-VY8/edit?usp=sharing) Hopefully, we can avoid this by using cc_shared_library rule in future. Change-Id: I23640d4caf8afe65d60b1522af6368536d7a8408 PiperOrigin-RevId: 168829958
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java')
-rw-r--r--src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java b/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
index f3525b3e4c..ca994963a8 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
@@ -165,6 +165,11 @@ public final class BazelAnalysisMock extends AnalysisMock {
"cc_binary(name='launcher', srcs=['launcher_main.cc'])");
config.create(
+ "/bazel_tools_workspace/tools/def_parser/BUILD",
+ "package(default_visibility=['//visibility:public'])",
+ "filegroup(name='def_parser', srcs=['def_parser.exe'])");
+
+ config.create(
"/bazel_tools_workspace/objcproto/BUILD",
"package(default_visibility=['//visibility:public'])",
"objc_library(",