diff options
| author |  Greg Estren <gregce@google.com> | 2016-09-21 21:18:19 +0000 |
|---|---|---|
| committer |  Laszlo Csomor <laszlocsomor@google.com> | 2016-09-22 09:54:39 +0000 |
| commit | 1d8ba90781fb3075cdb10ee788971cc3a7c96299 (patch) | |
| tree | 23bc2be230e30cf426a637c45890860e686fd8f3 /src/test/java/com/google/devtools/build/lib/analysis/config | |
| parent | f0a716ae7145f1e815cd59b8d71ff037c40a3fa5 (diff) | |
Split dynamic configurations mode into:
--experimental_dynamic_configs=off - don't use dynamic configs
--experimental_dynamic_configs=on - use dynamic configs with trimmed fragments
--experimental_dynamic_configs=notrim - use dynamic configs with all fragments
This lets us decouple two independent dimensions of dynamic configurations: 1) being able to trigger new configurations and transitions anywhere and 2) only including the fragments needed by a target's transitive closure.
2) is likely to take much more time and effort to properly finesse (three notable challenges: late-bound attributes, aspects, and dynamic shedding of output path names). But 1) by itself already yields significant benefits. So in the name of starting to shift the config work from backend theory to stuff real builds actually use, this change lets us focus on productionizing 1) without blocking on getting all of 2) working first.
tl;dr: iterable deployment and all that.
--
MOS_MIGRATED_REVID=133874661
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/config')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java b/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java index 8f9e44311b..b1bdd87e3d 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java @@ -298,9 +298,12 @@ public class BuildConfigurationTest extends ConfigurationTestCase { @Test public void testNoDistinctHostConfigurationUnsupportedWithDynamicConfigs() throws Exception { - checkError( - "--nodistinct_host_configuration does not currently work with dynamic configurations", - "--nodistinct_host_configuration", "--experimental_dynamic_configs"); + String expectedError = + "--nodistinct_host_configuration does not currently work with dynamic configurations"; + checkError(expectedError, + "--nodistinct_host_configuration", "--experimental_dynamic_configs=on"); + checkError(expectedError, + "--nodistinct_host_configuration", "--experimental_dynamic_configs=notrim"); } @Test |