diff options
author | lberki <lberki@google.com> | 2017-10-26 09:41:52 +0200 |
---|---|---|
committer | Dmitry Lomov <dslomov@google.com> | 2017-10-26 10:59:38 +0200 |
commit | e012dcff33c26f5054066d5b8d9c26d356d5a30b (patch) | |
tree | 8ad761872eada6fd414d66dfcb118c4eb745e202 /src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java | |
parent | 0dffc49f528c4c6e641221060e41aa6896310bdf (diff) |
Remove OS/Xcode versions (and thus package loading) from AppleConfiguration.Loader.
This is a roll-forward of https://github.com/bazelbuild/bazel/commit/f9a379157d1e992390c5b6f0b75ef853e0870689, which was rolled back in https://github.com/bazelbuild/bazel/commit/0446714686119dd97f8d1f99290f98db91a65e44.
Fixes #3424 (again!)
RELNOTES[INC]: Selecting on "xcode_version" and
"{ios,tvos,macos,watchos}_sdk_version" is not supported anymore. What was config_setting(values={"$FOO_version": $VALUE}) is now config_setting(flag_values={"@bazel_tools//tools/osx:$FOO_versi...
PiperOrigin-RevId: 173505814
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java index ae217d3b54..b0a5585470 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java @@ -1108,23 +1108,6 @@ public class BuildViewTest extends BuildViewTestBase { } @Test - public void testMissingXcodeVersion() throws Exception { - // The xcode_version flag uses yet another code path on top of the redirect chaser. - // Note that the redirect chaser throws if it can't find a package, but doesn't throw if it - // can't find a label in a package - that's why we use an empty package here. - scratch.file("xcode/BUILD"); - useConfiguration("--xcode_version=1.2", "--xcode_version_config=//xcode:does_not_exist"); - reporter.removeHandler(failFastHandler); - try { - update(defaultFlags().with(Flag.KEEP_GOING)); - fail(); - } catch (InvalidConfigurationException e) { - assertThat(e).hasMessageThat().contains("//xcode:does_not_exist"); - } - } - - - @Test public void testVisibilityReferencesNonexistentPackage() throws Exception { scratch.file("z/a/BUILD", "py_library(name='a', visibility=['//nonexistent:nothing'])"); |