diff options
author | 2016-03-21 08:35:35 +0000 | |
---|---|---|
committer | 2016-03-21 09:37:14 +0000 | |
commit | 7857c798300c4eea9cf2172531f150f261ce158d (patch) | |
tree | 4c720a0c52c5a188a95be398b086db938e6062f5 /src/test/java/com/google/devtools/build/lib/actions | |
parent | 5059a1d26ef86360cc7d701b7cc4bcb322cf6bd1 (diff) |
Make ActionOwner a final class, since all non-test implementations were basically doing the same thing with it.
This simplifies the code and avoids unnecessary re-wrapping, which saves memory.
--
MOS_MIGRATED_REVID=117693050
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/actions')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java | 25 |
1 files changed, 3 insertions, 22 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java b/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java index f99503f583..15b6503a35 100644 --- a/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java +++ b/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java @@ -24,7 +24,6 @@ import com.google.common.collect.Iterables; import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.devtools.build.lib.actions.AbstractAction; -import com.google.devtools.build.lib.actions.AbstractActionOwner; import com.google.devtools.build.lib.actions.Action; import com.google.devtools.build.lib.actions.ActionExecutionContext; import com.google.devtools.build.lib.actions.ActionGraph; @@ -166,31 +165,13 @@ public final class ActionsTestUtil { } } - /** - * A dummy ActionOwner implementation for use in tests. - */ - public static class NullActionOwner extends AbstractActionOwner { - @Override - public Label getLabel() { - return NULL_LABEL; - } - - @Override - public String getConfigurationMnemonic() { - return "dummy-configuration-mnemonic"; - } - - @Override - public final String getConfigurationChecksum() { - return "dummy-configuration"; - } - } - public static final Artifact DUMMY_ARTIFACT = new Artifact( new PathFragment("dummy"), Root.asSourceRoot(new InMemoryFileSystem().getRootDirectory())); - public static final ActionOwner NULL_ACTION_OWNER = new NullActionOwner(); + public static final ActionOwner NULL_ACTION_OWNER = + new ActionOwner( + NULL_LABEL, null, "dummy-configuration-mnemonic", null, "dummy-configuration", null); public static final ArtifactOwner NULL_ARTIFACT_OWNER = new ArtifactOwner() { |