diff options
author | Yun Peng <pcloudy@google.com> | 2018-06-25 05:35:50 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-06-25 05:36:55 -0700 |
commit | 40f5a773e97d0e389838becd3fe0a8ab43853999 (patch) | |
tree | 2c2aec321caa559b43787281fd097a7545eacc28 /src/test/cpp | |
parent | d753745d58fc45fcb50623073829644812083da0 (diff) |
Windows: Native launcher now works with unicode.
The native launcher can now launch Java and Bash binary in
directory with non-English characters.
Unfortunately, python doesn't support running python zip file under
directory with non-English characters. eg. python ./??/bin.zip will
still fail.
See https://github.com/bazelbuild/bazel/issues/4473
Change-Id: I77fe9cdaabffc2e0d25c7097da5c0c9333a9c4a3
PiperOrigin-RevId: 201939391
Diffstat (limited to 'src/test/cpp')
-rw-r--r-- | src/test/cpp/util/file_test.cc | 2 | ||||
-rw-r--r-- | src/test/cpp/util/path_windows_test.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/test/cpp/util/file_test.cc b/src/test/cpp/util/file_test.cc index a7eb9c7614..eeb1e2c468 100644 --- a/src/test/cpp/util/file_test.cc +++ b/src/test/cpp/util/file_test.cc @@ -249,7 +249,7 @@ TEST(FileTest, IsDevNullTest) { ASSERT_FALSE(IsDevNull("dev/null")); ASSERT_FALSE(IsDevNull("/dev/nul")); ASSERT_FALSE(IsDevNull("/dev/nulll")); - ASSERT_FALSE(IsDevNull(NULL)); + ASSERT_FALSE(IsDevNull((char *) nullptr)); ASSERT_FALSE(IsDevNull("")); } diff --git a/src/test/cpp/util/path_windows_test.cc b/src/test/cpp/util/path_windows_test.cc index bcf62622d5..965d885c08 100644 --- a/src/test/cpp/util/path_windows_test.cc +++ b/src/test/cpp/util/path_windows_test.cc @@ -309,7 +309,7 @@ TEST(PathWindowsTest, IsWindowsDevNullTest) { ASSERT_FALSE(IsDevNull("/dev/nul")); ASSERT_FALSE(IsDevNull("/dev/nulll")); ASSERT_FALSE(IsDevNull("nu")); - ASSERT_FALSE(IsDevNull(NULL)); + ASSERT_FALSE(IsDevNull((char *) nullptr)); ASSERT_FALSE(IsDevNull("")); } |