Don't unnecessarily concatenate Strings just for an error message in an IllegalStateException that might not be thrown at all.

--
MOS_MIGRATED_REVID=101748191

1 files changed, 3 insertions, 3 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Rule.java b/src/main/java/com/google/devtools/build/lib/packages/Rule.java
index 76f6d47428..a4a46bcab9 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Rule.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Rule.java
@@ -656,10 +656,10 @@ public final class Rule implements Target {
     }
   }
 
-  private void checkForNullLabel(Label labelToCheck, String where) {
+  private void checkForNullLabel(Label labelToCheck, Object context) {
     if (labelToCheck == null) {
       throw new IllegalStateException(String.format(
-          "null label in rule %s, %s", getLabel().toString(), where));
+          "null label in rule %s, %s", getLabel().toString(), context));
     }
   }
 
@@ -672,7 +672,7 @@ public final class Rule implements Target {
         new AttributeMap.AcceptsLabelAttribute() {
           @Override
           public void acceptLabelAttribute(Label labelToCheck, Attribute attribute) {
-            checkForNullLabel(labelToCheck, "attribute " + attribute.getName());
+            checkForNullLabel(labelToCheck, attribute);
           }
         });
     for (OutputFile outputFile : getOutputFiles()) {