aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
diff options
context:
space:
mode:
authorGravatar Dmitry Lomov <dslomov@google.com>2018-01-15 04:00:04 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-15 04:02:00 -0800
commitf0711024f90541727fab60760f2d1affe12cc917 (patch)
tree2fda5922dde299e6926ced7c25ed9b99b6996bc6 /src/main
parent146ff24aa89f3c5b0f0c0b1b0cfc4bc5640c0797 (diff)
Properly report missing external repositiones during pattern evaluation.
Fixes #3836. Change-Id: Icc9e8e08c4336fc20f46b6b878986b991d62ab18 PiperOrigin-RevId: 181949937
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java b/src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java
index 285c45fa1c..9dc0b1c3f0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/EnvironmentBackedRecursivePackageProvider.java
@@ -146,9 +146,8 @@ public final class EnvironmentBackedRecursivePackageProvider implements Recursiv
}
if (!repositoryValue.repositoryExists()) {
- // This shouldn't be possible; we're given a repository, so we assume that the caller has
- // already checked for its existence.
- throw new IllegalStateException(String.format("No such repository '%s'", repository));
+ eventHandler.handle(Event.error(String.format("No such repository '%s'", repository)));
+ return ImmutableList.of();
}
roots.add(repositoryValue.getPath());
}