aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
diff options
context:
space:
mode:
authorGravatar Michajlo Matijkiw <michajlo@google.com>2015-08-12 18:16:58 +0000
committerGravatar Florian Weikert <fwe@google.com>2015-08-13 14:01:29 +0000
commitdda04e2b656f58e89ef269c5de1785d6c680e293 (patch)
treeb8032919076b850073aada44dbe6b793403a04ad /src/main
parent583c356d5b5d01516ba07e79ae54c7fd3769ebfb (diff)
Resolve TODO in BlazeCommandEventHandler
-- MOS_MIGRATED_REVID=100494619
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandEventHandler.java11
1 files changed, 4 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandEventHandler.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandEventHandler.java
index 4cf491b991..90a8db6f15 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandEventHandler.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandEventHandler.java
@@ -17,7 +17,6 @@ import com.google.devtools.build.lib.events.Event;
import com.google.devtools.build.lib.events.EventHandler;
import com.google.devtools.build.lib.events.EventKind;
import com.google.devtools.build.lib.events.Location;
-import com.google.devtools.build.lib.util.LoggingUtil;
import com.google.devtools.build.lib.util.io.OutErr;
import com.google.devtools.common.options.EnumConverter;
import com.google.devtools.common.options.Option;
@@ -247,12 +246,10 @@ public class BlazeCommandEventHandler implements EventHandler {
out.write(event.getMessageBytes());
out.flush();
} catch (IOException e) {
- // This can happen in server mode if the blaze client has exited,
- // or if output is redirected to a file and the disk is full, etc.
- // TODO(bazel-team): Maybe crash here after gathering some data on how common this is.
- String message = "Failed to write event";
- LOG.log(Level.WARNING, message, e);
- LoggingUtil.logToRemote(Level.WARNING, message, e);
+ // This can happen in server mode if the blaze client has exited, or if output is redirected
+ // to a file and the disk is full, etc. May be moot in the case of full disk, or useful in
+ // the case of real bug in our handling of streams.
+ LOG.log(Level.WARNING, "Failed to write event", e);
}
}