Document ambigious literal arguments when calling CcToolchainProvider constructor

RELNOTES: None.
PiperOrigin-RevId: 186744674

1 files changed, 30 insertions, 29 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProvider.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProvider.java
index 1921c364bf..647fe72db7 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProvider.java
@@ -52,37 +52,37 @@ public final class CcToolchainProvider extends ToolchainInfo {
   /** An empty toolchain to be returned in the error case (instead of null). */
   public static final CcToolchainProvider EMPTY_TOOLCHAIN_IS_ERROR =
       new CcToolchainProvider(
-          ImmutableMap.of(),
-          null,
-          null,
-          null,
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          null,
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          null,
-          NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
-          null,
-          PathFragment.EMPTY_FRAGMENT,
+          /* skylarkToolchain= */ ImmutableMap.of(),
+          /* cppConfiguration= */ null,
+          /* toolchainInfo= */ null,
+          /* crosstoolTopPathFragment= */ null,
+          /* crosstool= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* crosstoolMiddleman= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* compile= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* strip= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* objCopy= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* as= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* ar= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* link= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* interfaceSoBuilder= */ null,
+          /* dwp= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* coverage= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* libcLink= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* staticRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* staticRuntimeLinkMiddleman= */ null,
+          /* dynamicRuntimeLinkInputs= */ NestedSetBuilder.<Artifact>emptySet(Order.STABLE_ORDER),
+          /* dynamicRuntimeLinkMiddleman= */ null,
+          /* dynamicRuntimeSolibDir= */ PathFragment.EMPTY_FRAGMENT,
           CcCompilationInfo.EMPTY,
-          false,
-          false,
+          /* supportsParamFiles= */ false,
+          /* supportsHeaderParsing= */ false,
           Variables.EMPTY,
-          ImmutableList.<Artifact>of(),
-          NestedSetBuilder.<Pair<String, String>>emptySet(Order.COMPILE_ORDER),
-          null,
-          ImmutableMap.<String, String>of(),
-          ImmutableList.<PathFragment>of(),
-          null,
+          /* builtinIncludeFiles= */ ImmutableList.<Artifact>of(),
+          /* coverageEnvironment= */ NestedSetBuilder.emptySet(Order.COMPILE_ORDER),
+          /* linkDynamicLibraryTool= */ null,
+          /* environment= */ ImmutableMap.<String, String>of(),
+          /* builtInIncludeDirectories= */ ImmutableList.<PathFragment>of(),
+          /* sysroot= */ null,
           FdoMode.OFF);
 
   @Nullable private final CppConfiguration cppConfiguration;
@@ -826,3 +826,4 @@ public final class CcToolchainProvider extends ToolchainInfo {
     return System.identityHashCode(this);
   }
 }
+