Remove INTERNAL flags from help flags-as-proto.

These flags cannot be specified under any circumstances - the parser treats
them as absent, and they can't be named in config_setting, etc. - so listing
them here doesn't help anyone.

RELNOTES: None.
PiperOrigin-RevId: 194419952

1 files changed, 5 insertions, 0 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/commands/HelpCommand.java b/src/main/java/com/google/devtools/build/lib/runtime/commands/HelpCommand.java
index 4de7cbf5f8..acd43a0aae 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/commands/HelpCommand.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/commands/HelpCommand.java
@@ -18,6 +18,7 @@ import com.google.common.base.Joiner;
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.ImmutableSortedMap;
 import com.google.common.collect.Iterables;
 import com.google.common.escape.Escaper;
@@ -250,6 +251,10 @@ public final class HelpCommand implements BlazeCommand {
     Predicate<OptionDefinition> allOptions = option -> true;
     BiConsumer<String, OptionDefinition> visitor =
         (commandName, option) -> {
+          if (ImmutableSet.copyOf(option.getOptionMetadataTags())
+              .contains(OptionMetadataTag.INTERNAL)) {
+            return;
+          }
           BazelFlagsProto.FlagInfo.Builder info =
               flags.computeIfAbsent(option.getOptionName(), key -> createFlagInfo(option));
           info.addCommands(commandName);