aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
diff options
context:
space:
mode:
authorGravatar Michajlo Matijkiw <michajlo@google.com>2016-07-13 15:12:05 +0000
committerGravatar Kristina Chodorow <kchodorow@google.com>2016-07-14 11:12:02 +0000
commit4e4e0e1ecd722669633000eb2a73bcb6cf1c7f8d (patch)
tree9eea2d2f184a36e1d3300c186538abb4fc161ba0 /src/main
parentfb605ae0d6c7c1fe37dc36a208abae5b3643aa16 (diff)
Use BuiltinFunction name for profiling
BuiltInFunction#call is pretty popular, avoid constructing a new string, or any object for that matter, every time we call it. FWIW the class name probably won't be particularly useful anyway since most built ins are anonymous. -- MOS_MIGRATED_REVID=127318185
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
index eab18ce2be..533928c9c2 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/BuiltinFunction.java
@@ -20,13 +20,11 @@ import com.google.devtools.build.lib.profiler.ProfilerTask;
import com.google.devtools.build.lib.skylarkinterface.SkylarkSignature;
import com.google.devtools.build.lib.syntax.SkylarkType.SkylarkFunctionType;
import com.google.devtools.build.lib.util.Preconditions;
-
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.NoSuchElementException;
-
import javax.annotation.Nullable;
/**
@@ -149,8 +147,7 @@ public class BuiltinFunction extends BaseFunction {
}
}
- Profiler.instance().startTask(ProfilerTask.SKYLARK_BUILTIN_FN,
- this.getClass().getName() + "#" + getName());
+ Profiler.instance().startTask(ProfilerTask.SKYLARK_BUILTIN_FN, getName());
// Last but not least, actually make an inner call to the function with the resolved arguments.
try {
env.enterScope(this, ast, env.getGlobals());