BuildView#getConfiguredTargetForTesting respects null transitions.

RuleTransitionFactory#buildTransitionFor is @Nullable, but the
SkyframeExecutor expects a non-null Transition. If the factory
returns null, the SkyframeExecutor should be passed NONE, not null.

PiperOrigin-RevId: 151615724

1 files changed, 5 insertions, 1 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
index 2524deb5bc..c9709ab4ef 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
@@ -1101,7 +1101,11 @@ public class BuildView {
     RuleTransitionFactory factory = rule
         .getRuleClassObject()
         .getTransitionFactory();
-    return (factory == null) ? ConfigurationTransition.NONE : factory.buildTransitionFor(rule);
+    if (factory == null) {
+      return ConfigurationTransition.NONE;
+    }
+    Transition transition = factory.buildTransitionFor(rule);
+    return (transition == null) ? ConfigurationTransition.NONE : transition;
   }
 
   /**