aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
diff options
context:
space:
mode:
authorGravatar nharmata <nharmata@google.com>2018-01-19 09:39:28 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-19 09:41:33 -0800
commit26866939e115798cf91d7a02de5417ad81314384 (patch)
tree220b2b2b73e71333e89b443974bdf49cdc38a614 /src/main
parent8cc5dcf34cf5156db78ccf5f936ca3c8b893c36f (diff)
Hoist "continue" statement outside of inner loop.
RELNOTES: None PiperOrigin-RevId: 182546239
Diffstat (limited to 'src/main')
-rw-r--r--src/main/java/com/google/devtools/build/lib/buildtool/SymlinkForest.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/buildtool/SymlinkForest.java b/src/main/java/com/google/devtools/build/lib/buildtool/SymlinkForest.java
index 4b4f7cc5c4..13b57cf467 100644
--- a/src/main/java/com/google/devtools/build/lib/buildtool/SymlinkForest.java
+++ b/src/main/java/com/google/devtools/build/lib/buildtool/SymlinkForest.java
@@ -118,12 +118,12 @@ class SymlinkForest {
Map<PackageIdentifier, Set<Root>> dirRootsMap = Maps.newTreeMap();
for (Map.Entry<PackageIdentifier, Root> entry : packageRoots.entrySet()) {
PackageIdentifier pkgId = entry.getKey();
+ if (pkgId.equals(Label.EXTERNAL_PACKAGE_IDENTIFIER)) {
+ // This isn't a "real" package, don't add it to the symlink tree.
+ continue;
+ }
Root pkgRoot = entry.getValue();
for (int i = 1; i <= pkgId.getPackageFragment().segmentCount(); i++) {
- if (pkgId.equals(Label.EXTERNAL_PACKAGE_IDENTIFIER)) {
- // This isn't a "real" package, don't add it to the symlink tree.
- continue;
- }
PackageIdentifier dir = createInRepo(pkgId, pkgId.getPackageFragment().subFragment(0, i));
Set<Root> roots = dirRootsMap.computeIfAbsent(dir, k -> Sets.newHashSet());
roots.add(pkgRoot);