diff options
author | 2018-03-10 18:06:56 -0800 | |
---|---|---|
committer | 2018-03-10 18:08:28 -0800 | |
commit | 12b78feca3d131f3d76226deb694535357230bdd (patch) | |
tree | 1961a26e2ffcb1834fa75fe3bc94711cfe7c0fca /src/main | |
parent | 463e9f9c8bd89a50ddac93202c68fcd9934e8e0d (diff) |
Replace some #getConfiguration calls coming from a TransitiveInfoCollection that was obtained from a ConfiguredTargetAndData object anyway.
PiperOrigin-RevId: 188621245
Diffstat (limited to 'src/main')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java index 394f5721a7..ab0bb5e183 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java @@ -885,13 +885,11 @@ public final class RuleContext extends TargetContext public <C extends Info> ImmutableListMultimap<BuildConfiguration, C> getPrerequisitesByConfiguration( String attributeName, Mode mode, final NativeProvider<C> provider) { - List<? extends TransitiveInfoCollection> transitiveInfoCollections = - getPrerequisites(attributeName, mode); - ImmutableListMultimap.Builder<BuildConfiguration, C> result = ImmutableListMultimap.builder(); - for (TransitiveInfoCollection prerequisite : transitiveInfoCollections) { - C prerequisiteProvider = prerequisite.get(provider); + for (ConfiguredTargetAndData prerequisite : + getPrerequisiteConfiguredTargetAndTargets(attributeName, mode)) { + C prerequisiteProvider = prerequisite.getConfiguredTarget().get(provider); if (prerequisiteProvider != null) { result.put(prerequisite.getConfiguration(), prerequisiteProvider); } @@ -906,13 +904,11 @@ public final class RuleContext extends TargetContext */ public ImmutableListMultimap<BuildConfiguration, TransitiveInfoCollection> getPrerequisitesByConfiguration(String attributeName, Mode mode) { - List<? extends TransitiveInfoCollection> transitiveInfoCollections = - getPrerequisites(attributeName, mode); - ImmutableListMultimap.Builder<BuildConfiguration, TransitiveInfoCollection> result = ImmutableListMultimap.builder(); - for (TransitiveInfoCollection prerequisite : transitiveInfoCollections) { - result.put(prerequisite.getConfiguration(), prerequisite); + for (ConfiguredTargetAndData prerequisite : + getPrerequisiteConfiguredTargetAndTargets(attributeName, mode)) { + result.put(prerequisite.getConfiguration(), prerequisite.getConfiguredTarget()); } return result.build(); } |