diff options
author | Michajlo Matijkiw <michajlo@google.com> | 2017-01-23 16:47:31 +0000 |
---|---|---|
committer | John Cater <jcater@google.com> | 2017-01-23 19:39:23 +0000 |
commit | a9f7efc69f170c5c9c52b219abcbd63b8d535181 (patch) | |
tree | 36f1d6a215b82ef5d78bffac359375c6854f9be7 /src/main/java | |
parent | 65df9012577e6f8749b2e448e340d5198af68a17 (diff) |
Minimize SpawnAction constructor exposure
One's unused, the other is ok as protected.
--
PiperOrigin-RevId: 145291062
MOS_MIGRATED_REVID=145291062
Diffstat (limited to 'src/main/java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java b/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java index 607028f5cb..b7a094a469 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/actions/SpawnAction.java @@ -437,11 +437,11 @@ public class SpawnAction extends AbstractAction implements ExecutionInfoSpecifie /** * Creates an ActionSpawn with the given environment variables. - * + * * <p>Subclasses of ActionSpawn may subclass in order to provide action-specific values for * environment variables or action inputs. */ - public ActionSpawn(Map<String, String> clientEnv) { + protected ActionSpawn(Map<String, String> clientEnv) { super(ImmutableList.copyOf(argv.arguments()), ImmutableMap.<String, String>of(), executionInfo, @@ -467,13 +467,6 @@ public class SpawnAction extends AbstractAction implements ExecutionInfoSpecifie effectiveEnvironment = ImmutableMap.copyOf(env); } - /** - * Creates an ActionSpawn with no environment variables. - */ - public ActionSpawn() { - this(null); - } - @Override public ImmutableMap<String, String> getEnvironment() { return effectiveEnvironment; @@ -1132,7 +1125,7 @@ public class SpawnAction extends AbstractAction implements ExecutionInfoSpecifie public <T> Builder setExtraActionInfo( GeneratedExtension<ExtraActionInfo, T> extension, T value) { - this.extraActionInfoSupplier = new ExtraActionInfoSupplier<T>(extension, value); + this.extraActionInfoSupplier = new ExtraActionInfoSupplier<>(extension, value); return this; } |