diff options
| author |  Dave MacLachlan <dmaclach@google.com> | 2016-03-11 21:49:32 +0000 |
|---|---|---|
| committer |  Dmitry Lomov <dslomov@google.com> | 2016-03-14 13:52:33 +0000 |
| commit | 74899385ed41baa411abe10071e1f1c0841b1295 (patch) | |
| tree | 5d819e7b1a31321e8a271a980f41191d0c75a02c /src/main/java | |
| parent | 4dd3e38134ad788b118116102e3a81c05f332d6a (diff) | |
Makes the xctest_app attribute of ios_test only accept ios_applications. It used to accept obc_binaries as well.
RELNOTES: You can no longer use objc_binary targets for the xctest_app attribute of an ios_test rule.
--
MOS_MIGRATED_REVID=117004358
Diffstat (limited to 'src/main/java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java index 4d14e50399..b758e525b7 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/IosTestRule.java @@ -77,9 +77,8 @@ public class IosTestRule implements RuleDefinition { <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/ .add(attr(IosTest.IS_XCTEST_ATTR, BOOLEAN).value(true)) /* <!-- #BLAZE_RULE(ios_test).ATTRIBUTE(xctest_app) --> - A <code>objc_binary</code> or <code>ios_application</code> target that contains the - app bundle to test against in XCTest. - This attribute is only valid if <code>xctest</code> is true. + An <code>ios_application</code> target that contains the app bundle to test against with + XCTest. This attribute is only valid if <code>xctest</code> is true. <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/ .add( attr(IosTest.XCTEST_APP_ATTR, LABEL) @@ -96,8 +95,7 @@ public class IosTestRule implements RuleDefinition { } }) .allowedFileTypes() - // TODO(bazel-team): Remove objc_binary once it stops exporting XcTestAppProvider. - .allowedRuleClasses("objc_binary", "ios_application")) + .allowedRuleClasses("ios_application")) .override( attr(BundlingRule.INFOPLIST_ATTR, LABEL) .value( |