aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java
diff options
context:
space:
mode:
authorGravatar tomlu <tomlu@google.com>2017-06-21 23:57:33 +0200
committerGravatar Philipp Wollermann <philwo@google.com>2017-06-22 12:43:31 +0200
commit21a01ff03f3dd817bd7bba52b9b3b8c81c49cde6 (patch)
tree3cc874741ff1475654935a627724d639c7a168c5 /src/main/java
parentbf2e2d8003a2418941404741fce82f1e51b3b28b (diff)
Fix source jars no longer being exposed to Skylark from java_library.
Regression test added for java_library. Unfortunately, due to the nature of the skylark provider, similar regression tests should probably be added to every Java providing rule. In the long term, the better solution is to expose JavaProvider directly and remove JavaSkylarkApiProvider. Fixes #3238 PiperOrigin-RevId: 159748655
Diffstat (limited to 'src/main/java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java
index c08ddb7f2c..81f051d813 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaLibrary.java
@@ -239,6 +239,7 @@ public class JavaLibrary implements RuleConfiguredTargetFactory {
// TODO(bazel-team): this should only happen for java_plugin
.addProvider(JavaCommon.getTransitivePlugins(ruleContext))
.addProvider(new ProguardSpecProvider(proguardSpecs))
+ .addProvider(sourceJarsProvider)
.addOutputGroup(JavaSemantics.SOURCE_JARS_OUTPUT_GROUP, transitiveSourceJars)
.addOutputGroup(OutputGroupProvider.HIDDEN_TOP_LEVEL, proguardSpecs);