diff options
| author |  Greg Estren <gregce@google.com> | 2015-04-09 21:58:28 +0000 |
|---|---|---|
| committer |  Ulf Adams <ulfjack@google.com> | 2015-04-10 08:03:29 +0000 |
| commit | 92e30d98c1609fb5f84a52585b3cd8c5ebc9f9ab (patch) | |
| tree | e7967caf8bb46d32c22a36e49df78daaf923dfd3 /src/main/java/com | |
| parent | 9186f68b7325261f1598df021c0ca45c15d2835c (diff) | |
Provide cleaner syntax error messages using select.
Given:
genrule(srcs = ['somefile'] + select({...}))
Before this change:
ERROR: unsupported operand type(s) for +: 'List' and 'SelectorValue'
After this change:
ERROR: unsupported operand type(s) for +: 'List' and 'select'
--
MOS_MIGRATED_REVID=90750232
Diffstat (limited to 'src/main/java/com')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java b/src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java index 9610c80baf..db47743459 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java @@ -234,6 +234,8 @@ public abstract class EvalUtils { return "function"; } else if (c.equals(FilesetEntry.class)) { return "FilesetEntry"; + } else if (c.equals(SelectorValue.class)) { + return "select"; } else if (NestedSet.class.isAssignableFrom(c) || SkylarkNestedSet.class.isAssignableFrom(c)) { return "set"; } else if (ClassObject.SkylarkClassObject.class.isAssignableFrom(c)) { |