diff options
author | 2015-10-19 12:28:03 +0000 | |
---|---|---|
committer | 2015-10-19 13:44:17 +0000 | |
commit | 8ff216d8e8a1c3fc5ed33453bb21b53381e295c9 (patch) | |
tree | 5ab9e1818ed43b4103b80badf64f0a158c1f5735 /src/main/java/com | |
parent | eb851fe67fcd06660bc49a56fb44fe03a748aa17 (diff) |
Quick workaround for #473 that reenables hdrs_check in Bazel to unblock the release. Note the following peculiarities of the current situation:
- Sandboxed execution still silently falls back to non-sandboxed execution due to LocalGccStrategy explicitly requesting local execution.
- However, builds are still correct due to local execution using hdrs_check.
- hdrs_check, even though it was intended to default to "strict" in Bazel from the start, is still set to "loose" by default, so you might accidentally be using non-declared header files in your cc_* targets. In this case, your builds will break when the default becomes hdrs_check=strict and sandboxing becomes available. It is recommended that you check whether your builds are affected, by specifying --hdrs_check=strict manually and fixing your BUILD files to explicitly list all used includes in the srcs / hdrs attributes of your cc_* targets.
These remaining issues will be fixed in an upcoming change.
This change also adds regression tests for the issue.
--
MOS_MIGRATED_REVID=105747212
Diffstat (limited to 'src/main/java/com')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/Constants.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/Constants.java b/src/main/java/com/google/devtools/build/lib/Constants.java index 940fa0e535..1606b7e054 100644 --- a/src/main/java/com/google/devtools/build/lib/Constants.java +++ b/src/main/java/com/google/devtools/build/lib/Constants.java @@ -44,5 +44,5 @@ public class Constants { * Whether C++ include scanning should be disabled no matter what the --cc_include_scanning flag * says. */ - public static final boolean HARD_DISABLE_CC_INCLUDE_SCANNING = true; + public static final boolean HARD_DISABLE_CC_INCLUDE_SCANNING = new Boolean(false).booleanValue(); } |