aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2016-11-30 18:13:59 +0000
committerGravatar Irina Iancu <elenairina@google.com>2016-12-01 10:15:23 +0000
commit4fe1047e13c7565c419b98ac060e44e63da1a48d (patch)
treea011cb11cf48041f15e0d2aa036a39dc77fe6023 /src/main/java/com
parentee3aa9eaf87682ddbd1e02ae29254332a1bce09b (diff)
Re-enable modules pruning for fake compile actions. I think our initial
assessment was wrong and this does work properly now that all the inputs are properly declared. -- MOS_MIGRATED_REVID=140618631
Diffstat (limited to 'src/main/java/com')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java
index ca4c17758c..d1ee7f3967 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java
@@ -270,12 +270,9 @@ public class CppCompileActionBuilder {
// something that uses A (a header of it), we mark A and all of its transitive deps as inputs.
// We still don't need to rebuild A, as none of its inputs have changed, but we do rebuild B
// now and then the two modules are out of sync.
- // We also have to disable this for fake C++ compile actions as those currently do a build first
- // before discovering inputs and thus would not declare their inputs properly.
boolean shouldPruneModules =
shouldScanIncludes
&& useHeaderModules
- && !fake
&& !getActionName().equals(CppCompileAction.CPP_MODULE_COMPILE);
if (useHeaderModules && !shouldPruneModules) {
realMandatoryInputsBuilder.addTransitive(context.getTransitiveModules(usePic));