diff options
author | tomlu <tomlu@google.com> | 2017-08-28 19:33:17 +0200 |
---|---|---|
committer | Vladimir Moskva <vladmos@google.com> | 2017-08-29 13:31:24 +0200 |
commit | 2ae3eaea447820c5fd33f3b3eeb1cb0f9df4768c (patch) | |
tree | 800ca148c0f0ef45b591ee2bf0157a6d81f2c56c /src/main/java/com | |
parent | 6ccff29c57c9795d93eec496fdc7cfc3c135d58a (diff) |
Remove TODO from LegacyCompilationSupport.
PiperOrigin-RevId: 166722992
Diffstat (limited to 'src/main/java/com')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java b/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java index e65b5597f9..435070161e 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/LegacyCompilationSupport.java @@ -598,10 +598,8 @@ public class LegacyCompilationSupport extends CompilationSupport { ? StrippingType.DYNAMIC_LIB : StrippingType.DEFAULT; } catch (CommandLineExpansionException e) { - // TODO(b/64941219): This code should be rewritten to not expand the command line - // in the analysis phase // This can't actually happen, because the command lines used by this class do - // not throw. + // not throw. This class is slated for deletion, so throwing an assertion is good enough. throw new AssertionError("Cannot fail to expand command line but did.", e); } } |