aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google
diff options
context:
space:
mode:
authorGravatar nharmata <nharmata@google.com>2018-01-18 09:18:10 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-18 09:20:06 -0800
commit8e2ae53375c0a615c53ab4e10f27856025a83fb1 (patch)
treecef2fb8d3adf670039ddc50332c7eed0cca52254 /src/main/java/com/google
parentab0cdd55fc73b40f1c7462a2b95cc1ce7f930043 (diff)
Include the list of 'excludes' glob patterns in the error message used when an IOException is encountered from a Globber. The io error may have been encountered during evaluation of one of the 'excludes' patterns.
RELNOTES: None PiperOrigin-RevId: 182390180
Diffstat (limited to 'src/main/java/com/google')
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
index 79f6a9d0c7..daf3dfe247 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
@@ -582,8 +582,11 @@ public final class PackageFactory {
Globber.Token globToken = context.globber.runAsync(includes, excludes, excludeDirs);
matches = context.globber.fetch(globToken);
} catch (IOException e) {
- String errorMessage =
- "error globbing [" + Joiner.on(", ").join(includes) + "]: " + e.getMessage();
+ String errorMessage = String.format(
+ "error globbing [%s]%s: %s",
+ Joiner.on(", ").join(includes),
+ excludes.isEmpty() ? "" : " - [" + Joiner.on(", ").join(excludes) + "]",
+ e.getMessage());
context.eventHandler.handle(Event.error(ast.getLocation(), errorMessage));
context.pkgBuilder.setIOExceptionAndMessage(e, errorMessage);
matches = ImmutableList.of();