Don't log timing information in InvalidatingNodeVisitor. Instead, callers can log timing information if they wish.

--
MOS_MIGRATED_REVID=100712340

1 files changed, 0 insertions, 11 deletions

diff --git a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
index 7e2d2247d0..13d4dc1bcc 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InvalidatingNodeVisitor.java
@@ -22,14 +22,12 @@ import com.google.common.collect.Iterables;
 import com.google.common.collect.Sets;
 import com.google.devtools.build.lib.concurrent.AbstractQueueVisitor;
 import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe;
-import com.google.devtools.build.lib.profiler.Profiler;
 import com.google.devtools.build.lib.util.Pair;
 
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
-import java.util.logging.Logger;
 
 import javax.annotation.Nullable;
 
@@ -67,8 +65,6 @@ public abstract class InvalidatingNodeVisitor extends AbstractQueueVisitor {
   // Aliased to InvalidationState.pendingVisitations.
   protected final Set<Pair<SkyKey, InvalidationType>> pendingVisitations;
 
-  private static final Logger LOG = Logger.getLogger(InvalidatingNodeVisitor.class.getName());
-
   protected InvalidatingNodeVisitor(
       DirtiableGraph graph, @Nullable EvaluationProgressReceiver invalidationReceiver,
       InvalidationState state, DirtyKeyTracker dirtyKeyTracker) {
@@ -98,7 +94,6 @@ public abstract class InvalidatingNodeVisitor extends AbstractQueueVisitor {
    * Initiates visitation and waits for completion.
    */
   void run() throws InterruptedException {
-    long startTime = Profiler.nanoTimeMaybe();
     // Make a copy to avoid concurrent modification confusing us as to which nodes were passed by
     // the caller, and which are added by other threads during the run. Since no tasks have been
     // started yet (the queueDirtying calls start them), this is thread-safe.
@@ -109,12 +104,6 @@ public abstract class InvalidatingNodeVisitor extends AbstractQueueVisitor {
       visit(visitData.first, visitData.second, !MUST_EXIST);
     }
     work(/*failFastOnInterrupt=*/true);
-
-    long duration = Profiler.nanoTimeMaybe() - startTime;
-    if (duration > 0) {
-      LOG.info("Spent " + TimeUnit.NANOSECONDS.toMillis(duration) + " ms invalidating "
-                   + count() + " nodes");
-    }
     Preconditions.checkState(pendingVisitations.isEmpty(),
         "All dirty nodes should have been processed: %s", pendingVisitations);
   }