diff options
author | Carmi Grushko <carmi@google.com> | 2016-12-09 23:05:28 +0000 |
---|---|---|
committer | John Cater <jcater@google.com> | 2016-12-12 20:35:16 +0000 |
commit | 68e850ff8df0e381bd224d9926b400b7320d4fb8 (patch) | |
tree | 9ac0736570a6ddce48219ff8de13c9200d4ee685 /src/main/java/com/google | |
parent | b5f480cb7c79ccbd938e5892834736dd4d3b5eef (diff) |
Strict proto deps: .proto files are allowed to import other .proto files in the same srcs as they are.
--
PiperOrigin-RevId: 141604925
MOS_MIGRATED_REVID=141604925
Diffstat (limited to 'src/main/java/com/google')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java index e1eef7f3f4..80bd133607 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java +++ b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java @@ -172,7 +172,8 @@ public class ProtoCommon { @Nullable public static NestedSet<Artifact> computeProtosInDirectDeps(RuleContext ruleContext) { NestedSetBuilder<Artifact> result = NestedSetBuilder.stableOrder(); - if (ruleContext.getPrerequisiteArtifacts("srcs", TARGET).list().isEmpty()) { + ImmutableList<Artifact> srcs = ruleContext.getPrerequisiteArtifacts("srcs", TARGET).list(); + if (srcs.isEmpty()) { for (ProtoSupportDataProvider provider : ruleContext.getPrerequisites("deps", TARGET, ProtoSupportDataProvider.class)) { result.addTransitive(provider.getSupportData().getProtosInDirectDeps()); @@ -182,6 +183,7 @@ public class ProtoCommon { ruleContext.getPrerequisites("deps", TARGET, ProtoSourcesProvider.class)) { result.addAll(provider.getCheckDepsProtoSources()); } + result.addAll(srcs); } return result.build(); } |