aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google
diff options
context:
space:
mode:
authorGravatar Carmi Grushko <carmi@google.com>2016-07-15 15:47:15 +0000
committerGravatar Yun Peng <pcloudy@google.com>2016-07-18 10:43:02 +0000
commit5ea55cbab969820da346d16c4998e957b8c3f60e (patch)
tree9de604d881de7af2796034a9cd7b27e96e4451f2 /src/main/java/com/google
parent278814b0fbf4ddf19d58344481814b8cd6e70c7d (diff)
Unveil Bazel's proto_library and java_proto_library.
-- MOS_MIGRATED_REVID=127543896
Diffstat (limited to 'src/main/java/com/google')
-rw-r--r--src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java2
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java7
2 files changed, 2 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java
index 990f0d2166..3886988a9f 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java
@@ -38,8 +38,6 @@ public class BazelJavaProtoLibraryRule implements RuleDefinition {
@Override
public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment environment) {
return builder
- // This rule isn't ready for use yet.
- .setUndocumented()
/* <!-- #BLAZE_RULE(java_proto_library).ATTRIBUTE(deps) -->
The list of <a href="protocol-buffer.html#proto_library"><code>proto_library</code></a>
rules to generate Java code for.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java
index 1f8b223b1f..d12f7570ac 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java
@@ -51,10 +51,6 @@ public final class BazelProtoLibraryRule implements RuleDefinition {
return builder
.requiresConfigurationFragments(ProtoConfiguration.class)
- // This rule works, but does nothing, in open-source Bazel, due to the
- // lack of protoc support. Users can theoretically write their own Skylark rules,
- // but these are still 'experimental' according to the documentation.
- .setUndocumented()
.setOutputToGenfiles()
.add(
attr(":proto_compiler", LABEL)
@@ -97,7 +93,8 @@ public final class BazelProtoLibraryRule implements RuleDefinition {
<p>Use <code>proto_library</code> to define libraries of protocol buffers
which may be used from multiple languages. A <code>proto_library</code> may be listed
- in the <code>deps</code> clause of supported rules, such as <code>objc_proto_library</code>.
+ in the <code>deps</code> clause of supported rules, such as <code>java_proto_library</code> and
+ <code>objc_proto_library</code>.
</p>
<!-- #END_BLAZE_RULE -->*/