Avoid the main use of String.format() during loading and analysis. This is

a noticeable hotspot in profiles.  (It would be even better if we could avoid
constructing this string until we actually need to produce an error message.)

--
MOS_MIGRATED_REVID=125323226

1 files changed, 1 insertions, 1 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
index edabbdaddb..6f4ffd784a 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java
@@ -1694,7 +1694,7 @@ public final class RuleClass {
    */
   private static Object convertFromBuildLangType(Rule rule, Attribute attr, Object buildLangValue)
       throws ConversionException {
-    String what = String.format("attribute '%s' in '%s' rule", attr.getName(), rule.getRuleClass());
+    String what = "attribute '" + attr.getName() + "' in '" + rule.getRuleClass() + "' rule";
     Object converted =
         BuildType.selectableConvert(attr.getType(), buildLangValue, what, rule.getLabel());