experimental UI: on failing tests, don't state "completed sucessfully"

Currently, if a build completes with tests failing, the final status
message is "INFO: Build completed successfully, xxx actions". While
technically correct, it might mislead the user to believing all tests
have passed (especially when only looking at the status in the terminal
title). Therefore, if a build completes with failing tests, mention the
number of failed tests in the final status message.

--
Change-Id: I9234fbfdf2ad43dd29af660966dde73bf0c9311a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3918
MOS_MIGRATED_REVID=126176452

1 files changed, 10 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalStateTracker.java b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalStateTracker.java
index ceee32143c..a3f4bceecb 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalStateTracker.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalStateTracker.java
@@ -156,8 +156,16 @@ class ExperimentalStateTracker {
   void buildComplete(BuildCompleteEvent event, String additionalInfo) {
     if (event.getResult().getSuccess()) {
       status = "INFO";
-      additionalMessage =
-          additionalInfo + "Build completed successfully, " + actionsCompleted + " total actions";
+      if (failedTests == 0) {
+        additionalMessage =
+            additionalInfo + "Build completed successfully, "
+            + actionsCompleted + " total action" + (actionsCompleted == 1 ? "" : "s");
+      } else {
+        additionalMessage =
+            additionalInfo + "Build completed, "
+            + failedTests + " test" + (failedTests == 1 ? "" : "s") + " FAILED, "
+            + actionsCompleted + " total action" + (actionsCompleted == 1 ? "" : "s");
+      }
     } else {
       ok = false;
       status = "FAILED";