diff options
author | 2015-08-28 22:10:00 +0000 | |
---|---|---|
committer | 2015-08-31 19:13:09 +0000 | |
commit | 42b02eead1037ab38c60266f014e98fa715a8a9c (patch) | |
tree | fb4f3dd9d7048df59c16194dfd1a4ab471c49449 /src/main/java/com/google/devtools | |
parent | f832d79463d53820e95719e7e6b0878c59666e37 (diff) |
Check argument isn't null when creating TransitiveTraversalValue error values
--
MOS_MIGRATED_REVID=101812326
Diffstat (limited to 'src/main/java/com/google/devtools')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTraversalValue.java | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTraversalValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTraversalValue.java index 829bc7d7f0..bed7220d11 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTraversalValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/TransitiveTraversalValue.java @@ -13,6 +13,7 @@ // limitations under the License. package com.google.devtools.build.lib.skyframe; +import com.google.common.base.Preconditions; import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe; import com.google.devtools.build.lib.packages.NoSuchTargetException; @@ -38,16 +39,16 @@ public class TransitiveTraversalValue implements SkyValue { // Note that this value does not guarantee singleton-like reference equality for successful // {@link TransitiveTraversalValue}s because we use Java deserialization. Java deserialization can // create other instances. - static final TransitiveTraversalValue SUCCESSFUL_TRANSITIVE_TRAVERSAL_VALUE = + public static final TransitiveTraversalValue SUCCESSFUL_TRANSITIVE_TRAVERSAL_VALUE = new TransitiveTraversalValue(null); - private TransitiveTraversalValue(@Nullable NoSuchTargetException errorLoadingTarget) { - this.errorLoadingTarget = errorLoadingTarget; + public static TransitiveTraversalValue unsuccessfulTransitiveTraversal( + NoSuchTargetException errorLoadingTarget) { + return new TransitiveTraversalValue(Preconditions.checkNotNull(errorLoadingTarget)); } - static TransitiveTraversalValue unsuccessfulTransitiveTraversal( - NoSuchTargetException errorLoadingTarget) { - return new TransitiveTraversalValue(errorLoadingTarget); + private TransitiveTraversalValue(@Nullable NoSuchTargetException errorLoadingTarget) { + this.errorLoadingTarget = errorLoadingTarget; } /** Returns the error, if any, from loading the target. */ |