diff options
| author |  vladmos <vladmos@google.com> | 2017-12-06 06:02:01 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2017-12-06 06:04:14 -0800 |
| commit | 31320246a1d428c0b56f78b98013961c68ed322d (patch) | |
| tree | b77f5e4b0eae8a4d98b16821a2e08cfc87365415 /src/main/java/com/google/devtools | |
| parent | 2cf560f83922e6df9626ba3ee063c1caf6797548 (diff) | |
Flip the --incompatible_disallow_uncalled_set_constructor flag
RELNOTES: The deprecated builtin `set` is no longer allowed even from within
unexecuted code in bzl files. It's temporarily possible to use
--incompatible_disallow_uncalled_set_constructor=false if this change causes
incompatibility issues.
PiperOrigin-RevId: 178087669
Diffstat (limited to 'src/main/java/com/google/devtools')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java | 2 | ||||
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java index dbb1d1cdb3..359cce86f0 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java @@ -160,7 +160,7 @@ public class SkylarkSemanticsOptions extends OptionsBase implements Serializable @Option( name = "incompatible_disallow_uncalled_set_constructor", - defaultValue = "false", + defaultValue = "true", category = "incompatible changes", documentationCategory = OptionDocumentationCategory.UNCATEGORIZED, effectTags = {OptionEffectTag.UNKNOWN}, diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java index 534416ae3b..3407be05c6 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java @@ -71,7 +71,7 @@ public abstract class SkylarkSemantics { .incompatibleDisallowDictPlus(false) .incompatibleDisallowKeywordOnlyArgs(true) .incompatibleDisallowToplevelIfStatement(true) - .incompatibleDisallowUncalledSetConstructor(false) + .incompatibleDisallowUncalledSetConstructor(true) .incompatibleListPlusEqualsInplace(true) .incompatibleLoadArgumentIsLabel(true) .incompatibleNewActionsApi(false) |