diff options
author | brandjon <brandjon@google.com> | 2017-09-22 23:33:38 -0400 |
---|---|---|
committer | John Cater <jcater@google.com> | 2017-09-25 09:38:59 -0400 |
commit | 95b0467e3eb42a8ce8d1179c0c7e1aab040e8120 (patch) | |
tree | 1311aaa083bdd2c9b67fade108fdbe524607f708 /src/main/java/com/google/devtools/skylark | |
parent | fefccdbfa28d8460c74b33dfc29a8aabc4d6a488 (diff) |
Cleanups for Skylark tracebacks
In Skylark.java, fix line numbers to start at 1 instead of 2.
In Eval.java, go through maybeTransformException for consistency with expressions, even though no statement nodes use this feature.
In EvalExceptionWithStackTrace, fix style violation (non-consecutive overloads) and add TODO explaining an open issue.
RELNOTES: None
PiperOrigin-RevId: 169769928
Diffstat (limited to 'src/main/java/com/google/devtools/skylark')
-rw-r--r-- | src/main/java/com/google/devtools/skylark/Skylark.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/skylark/Skylark.java b/src/main/java/com/google/devtools/skylark/Skylark.java index f7c7d11628..df7932e16b 100644 --- a/src/main/java/com/google/devtools/skylark/Skylark.java +++ b/src/main/java/com/google/devtools/skylark/Skylark.java @@ -64,6 +64,7 @@ class Skylark { StringBuilder input = new StringBuilder(); System.out.print(START_PROMPT); try { + String lineSeparator = ""; while (true) { String line = reader.readLine(); if (line == null) { @@ -72,7 +73,8 @@ class Skylark { if (line.isEmpty()) { return input.toString(); } - input.append("\n").append(line); + input.append(lineSeparator).append(line); + lineSeparator = "\n"; System.out.print(CONTINUATION_PROMPT); } } catch (IOException io) { |