diff options
| author |  brandjon <brandjon@google.com> | 2017-10-20 20:48:30 +0200 |
|---|---|---|
| committer |  Dmitry Lomov <dslomov@google.com> | 2017-10-23 17:16:02 +0200 |
| commit | 10a6b77e342472e29d168060e06f05a9c7cad66f (patch) | |
| tree | bd718474cb6a0379dc24c71ef0b32acec74a7cc2 /src/main/java/com/google/devtools/skylark | |
| parent | bc616ec5a44119b8e2b60293947e3aa14fac053f (diff) | |
Be explicit about semantics of Skylark environments
All callers that do not use Environment.Builder#setSemantics should call #useDefaultSemantics. A follow-up CL will enforce this requirement.
Motivation: It's more important that we are strict about semantics than about the other builder args. It's too easy for a mistake in semantics to go unnoticed.
RELNOTES: None
PiperOrigin-RevId: 172912829
Diffstat (limited to 'src/main/java/com/google/devtools/skylark')
| -rw-r--r-- | src/main/java/com/google/devtools/skylark/Skylark.java | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/skylark/Skylark.java b/src/main/java/com/google/devtools/skylark/Skylark.java index df7932e16b..cfa4d6f18e 100644 --- a/src/main/java/com/google/devtools/skylark/Skylark.java +++ b/src/main/java/com/google/devtools/skylark/Skylark.java @@ -56,6 +56,7 @@ class Skylark { private final Mutability mutability = Mutability.create("interpreter"); private final Environment env = Environment.builder(mutability) + .useDefaultSemantics() .setGlobals(Environment.DEFAULT_GLOBALS) .setEventHandler(PRINT_HANDLER) .build(); |