diff options
author | 2017-03-17 19:58:04 +0000 | |
---|---|---|
committer | 2017-03-20 11:41:35 +0000 | |
commit | 097e64c412c6a4162a22880fd435ef4632878406 (patch) | |
tree | fc74a9c67b94427d513a400cbb60168da5e01c67 /src/main/java/com/google/devtools/common/options/OptionsUsage.java | |
parent | 950ff6639bbdd22f2c1ae9dae91b2893de31de11 (diff) |
Refactor options converter logic
Moved default converters from parser implementation to Converters. Moved other helpers to OptionsData. Also factored out new function getFieldSingularType.
--
PiperOrigin-RevId: 150473455
MOS_MIGRATED_REVID=150473455
Diffstat (limited to 'src/main/java/com/google/devtools/common/options/OptionsUsage.java')
-rw-r--r-- | src/main/java/com/google/devtools/common/options/OptionsUsage.java | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/main/java/com/google/devtools/common/options/OptionsUsage.java b/src/main/java/com/google/devtools/common/options/OptionsUsage.java index b8c19df800..f3ee4d3536 100644 --- a/src/main/java/com/google/devtools/common/options/OptionsUsage.java +++ b/src/main/java/com/google/devtools/common/options/OptionsUsage.java @@ -13,14 +13,11 @@ // limitations under the License. package com.google.devtools.common.options; -import static com.google.devtools.common.options.OptionsParserImpl.findConverter; - import com.google.common.base.Joiner; import com.google.common.base.Splitter; import com.google.common.base.Strings; import com.google.common.collect.Lists; import com.google.common.escape.Escaper; - import java.lang.reflect.Field; import java.text.BreakIterator; import java.util.Collections; @@ -138,8 +135,7 @@ class OptionsUsage { Option annotation = optionField.getAnnotation(Option.class); usage.append("<dt><code><a name=\"flag--").append(plainFlagName).append("\"></a>--"); usage.append(flagName); - if (OptionsParserImpl.isBooleanField(optionField) - || OptionsParserImpl.isVoidField(optionField)) { + if (OptionsData.isBooleanField(optionField) || OptionsData.isVoidField(optionField)) { // Nothing for boolean, tristate, boolean_or_enum, or void options. } else if (!valueDescription.isEmpty()) { usage.append("=").append(escaper.escape(valueDescription)); @@ -157,7 +153,7 @@ class OptionsUsage { } else { // Don't call the annotation directly (we must allow overrides to certain defaults). String defaultValueString = OptionsParserImpl.getDefaultOptionString(optionField); - if (OptionsParserImpl.isVoidField(optionField)) { + if (OptionsData.isVoidField(optionField)) { // Void options don't have a default. } else if (OptionsParserImpl.isSpecialNullDefault(defaultValueString, optionField)) { usage.append(" default: see description"); @@ -259,12 +255,12 @@ class OptionsUsage { }; private static String getTypeDescription(Field optionsField) { - return findConverter(optionsField).getTypeDescription(); + return OptionsData.findConverter(optionsField).getTypeDescription(); } static String getFlagName(Field field) { String name = field.getAnnotation(Option.class).name(); - return OptionsParserImpl.isBooleanField(field) ? "[no]" + name : name; + return OptionsData.isBooleanField(field) ? "[no]" + name : name; } } |