diff options
| author |  Nathan Harmata <nharmata@google.com> | 2015-03-06 21:19:29 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2015-03-10 13:58:18 +0000 |
| commit | 9901cfbb8b4ba06236bce2ef2f69e0a21a71240a (patch) | |
| tree | a515ea8940d37ca778f27506ef0d1e43d11eecd1 /src/main/java/com/google/devtools/build | |
| parent | df22aafb5fb6eb557b7065c60720519e4a2d3795 (diff) | |
Remove obsolete comment about labels-crossing-subpackage check happening in legacy package loading. It now happens in skyframe package loading.
--
MOS_MIGRATED_REVID=87972524
Diffstat (limited to 'src/main/java/com/google/devtools/build')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java index 31991c4156..7f2f224757 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java @@ -282,8 +282,6 @@ public class PackageFunction implements SkyFunction { } packageShouldBeInError = markFileDepsAndPropagateInconsistentFilesystemExceptions( pkg.getName(), subincludeFileDepKeys, env, pkg.containsErrors()); - // Another concern is a subpackage cutting off the subinclude label, but this is already - // handled by the legacy package loading code which calls into our SkyframePackageLocator. // TODO(bazel-team): In the long term, we want to actually resolve the glob patterns within // Skyframe. For now, just logging the glob requests provides correct incrementality and |