aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2015-03-05 15:13:43 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-03-05 18:31:50 +0000
commit65562a26e3c587eaf8d84d8104209e68a33ccaab (patch)
treebb2d08bf2a97341f18ac06f025e435752d6c9adb /src/main/java/com/google/devtools/build
parent07dba941e21619830adcbcae10c5942cf3343f26 (diff)
List of file extensions supported in BaselineCoverageAction is moved to Constants.
-- MOS_MIGRATED_REVID=87823207
Diffstat (limited to 'src/main/java/com/google/devtools/build')
-rw-r--r--src/main/java/com/google/devtools/build/lib/Constants.java6
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/test/BaselineCoverageAction.java8
2 files changed, 9 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/Constants.java b/src/main/java/com/google/devtools/build/lib/Constants.java
index efc39ee2a5..7f6a518939 100644
--- a/src/main/java/com/google/devtools/build/lib/Constants.java
+++ b/src/main/java/com/google/devtools/build/lib/Constants.java
@@ -65,4 +65,10 @@ public class Constants {
"templates/attributes/test/size.html",
"templates/attributes/test/timeout.html",
"templates/attributes/test/flaky.html");
+
+ /**
+ * List of file extensions of which baseline coverage generation is supported.
+ */
+ public static final ImmutableList<String> BASELINE_COVERAGE_OFFLINE_INSTRUMENTATION_SUFFIXES =
+ ImmutableList.<String>of();
}
diff --git a/src/main/java/com/google/devtools/build/lib/rules/test/BaselineCoverageAction.java b/src/main/java/com/google/devtools/build/lib/rules/test/BaselineCoverageAction.java
index b341b32856..cb90155b80 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/test/BaselineCoverageAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/test/BaselineCoverageAction.java
@@ -17,6 +17,7 @@ package com.google.devtools.build.lib.rules.test;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.eventbus.EventBus;
+import com.google.devtools.build.lib.Constants;
import com.google.devtools.build.lib.actions.ActionOwner;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.Executor;
@@ -42,10 +43,7 @@ import java.util.List;
*/
public class BaselineCoverageAction extends AbstractFileWriteAction
implements NotifyOnActionCacheHit {
- // TODO(bazel-team): Remove this list of languages by separately collecting offline and online
- // instrumented files.
- private static final List<String> OFFLINE_INSTRUMENTATION_SUFFIXES = ImmutableList.of(
- ".c", ".cc", ".cpp", ".dart", ".go", ".h", ".java", ".py");
+
private final Iterable<Artifact> instrumentedFiles;
private BaselineCoverageAction(
@@ -70,7 +68,7 @@ public class BaselineCoverageAction extends AbstractFileWriteAction
List<String> result = new ArrayList<>();
for (Artifact instrumentedFile : instrumentedFiles) {
String pathString = instrumentedFile.getExecPathString();
- for (String suffix : OFFLINE_INSTRUMENTATION_SUFFIXES) {
+ for (String suffix : Constants.BASELINE_COVERAGE_OFFLINE_INSTRUMENTATION_SUFFIXES) {
if (pathString.endsWith(suffix)) {
result.add(pathString);
break;