diff options
| author |  Greg Estren <gregce@google.com> | 2016-08-18 22:01:29 +0000 |
|---|---|---|
| committer |  Philipp Wollermann <philwo@google.com> | 2016-08-19 09:52:54 +0000 |
| commit | 547295a59a60d7cf328d6d6ed46137bee97bb776 (patch) | |
| tree | 527bfb31389e0118cf642fb6d5151d44aadea1f9 /src/main/java/com/google/devtools/build | |
| parent | d0c5ff278a0c4cda57871f0b2a47a3c32e0c2b79 (diff) | |
Make test "args" attribute configurable.
A valid argument has been made for opening it up, and it's
not clear it's helping anyone by locking it down.
--
MOS_MIGRATED_REVID=130686109
Diffstat (limited to 'src/main/java/com/google/devtools/build')
3 files changed, 4 insertions, 9 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java index e43c609149..48cb299a74 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java @@ -126,8 +126,7 @@ public class BaseRuleClasses { .add(attr("shard_count", INTEGER).value(-1)) .add(attr("local", BOOLEAN).value(false).taggable() .nonconfigurable("policy decision: should be consistent across configurations")) - .add(attr("args", STRING_LIST) - .nonconfigurable("policy decision: should be consistent across configurations")) + .add(attr("args", STRING_LIST)) // Input files for every test action .add(attr("$test_runtime", LABEL_LIST).cfg(HOST).value(ImmutableList.of( env.getToolsLabel("//tools/test:runtime")))) diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelBaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelBaseRuleClasses.java index d6a5687af6..e0d3c7fa47 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelBaseRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelBaseRuleClasses.java @@ -44,8 +44,7 @@ public class BazelBaseRuleClasses { @Override public RuleClass build(Builder builder, RuleDefinitionEnvironment env) { return builder - .add(attr("args", STRING_LIST) - .nonconfigurable("policy decision: should be consistent across configurations")) + .add(attr("args", STRING_LIST)) .add(attr("output_licenses", LICENSE)) .add(attr("$is_executable", BOOLEAN).value(true) .nonconfigurable("Called from RunCommand.isExecutable, which takes a Target")) diff --git a/src/main/java/com/google/devtools/build/lib/rules/SkylarkRuleClassFunctions.java b/src/main/java/com/google/devtools/build/lib/rules/SkylarkRuleClassFunctions.java index 734ae0b3a1..a88e096667 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/SkylarkRuleClassFunctions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/SkylarkRuleClassFunctions.java @@ -144,9 +144,7 @@ public class SkylarkRuleClassFunctions { /** Parent rule class for executable non-test Skylark rules. */ public static final RuleClass binaryBaseRule = new RuleClass.Builder("$binary_base_rule", RuleClassType.ABSTRACT, true, baseRule) - .add( - attr("args", STRING_LIST) - .nonconfigurable("policy decision: should be consistent across configurations")) + .add(attr("args", STRING_LIST)) .add(attr("output_licenses", LICENSE)) .build(); @@ -175,8 +173,7 @@ public class SkylarkRuleClassFunctions { .add(attr("shard_count", INTEGER).value(-1)) .add(attr("local", BOOLEAN).value(false).taggable() .nonconfigurable("policy decision: this should be consistent across configurations")) - .add(attr("args", STRING_LIST) - .nonconfigurable("policy decision: should be consistent across configurations")) + .add(attr("args", STRING_LIST)) // Input files for every test action .add(attr("$test_runtime", LABEL_LIST).cfg(HOST).value(ImmutableList.of( labelCache.getUnchecked(toolsRepository + "//tools/test:runtime")))) |