aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2017-10-18 11:45:48 -0400
committerGravatar John Cater <jcater@google.com>2017-10-18 13:34:43 -0400
commit4f7be0f5f09533fe2f564f23e22aa5ddfcb5f630 (patch)
treecd822e2397a98bfb4351b57e85261aad74b02bf5 /src/main/java/com/google/devtools/build
parent1c3ee1a154fc63a127662ba9a83198c094075da9 (diff)
Push NodeEntry#keepEdges down to InMemoryNodeEntry. It's not needed on the general interface.
PiperOrigin-RevId: 172606623
Diffstat (limited to 'src/main/java/com/google/devtools/build')
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/DelegatingNodeEntry.java5
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java2
-rw-r--r--src/main/java/com/google/devtools/build/skyframe/NodeEntry.java2
3 files changed, 1 insertions, 8 deletions
diff --git a/src/main/java/com/google/devtools/build/skyframe/DelegatingNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/DelegatingNodeEntry.java
index e884954845..689b1cd9db 100644
--- a/src/main/java/com/google/devtools/build/skyframe/DelegatingNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/DelegatingNodeEntry.java
@@ -28,11 +28,6 @@ public abstract class DelegatingNodeEntry implements NodeEntry {
}
@Override
- public KeepEdgesPolicy keepEdges() {
- return getDelegate().keepEdges();
- }
-
- @Override
public SkyValue getValue() throws InterruptedException {
return getDelegate().getValue();
}
diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index 67e1867b7f..b94d2b1ac8 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -174,7 +174,7 @@ public class InMemoryNodeEntry implements NodeEntry {
public InMemoryNodeEntry() {
}
- @Override
+ // Public only for use in alternate graph implementations.
public KeepEdgesPolicy keepEdges() {
return KeepEdgesPolicy.ALL;
}
diff --git a/src/main/java/com/google/devtools/build/skyframe/NodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/NodeEntry.java
index 7857915fa2..a50284bf30 100644
--- a/src/main/java/com/google/devtools/build/skyframe/NodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/NodeEntry.java
@@ -75,8 +75,6 @@ public interface NodeEntry extends ThinNodeEntry {
REBUILDING
}
- KeepEdgesPolicy keepEdges();
-
/**
* Returns the value stored in this entry. This method may only be called after the evaluation of
* this node is complete, i.e., after {@link #setValue} has been called.